2014-07-18 20:37:27 +02:00
|
|
|
package command
|
|
|
|
|
|
|
|
import (
|
|
|
|
"fmt"
|
|
|
|
"strings"
|
terraform: ugly huge change to weave in new HCL2-oriented types
Due to how deeply the configuration types go into Terraform Core, there
isn't a great way to switch out to HCL2 gradually. As a consequence, this
huge commit gets us from the old state to a _compilable_ new state, but
does not yet attempt to fix any tests and has a number of known missing
parts and bugs. We will continue to iterate on this in forthcoming
commits, heading back towards passing tests and making Terraform
fully-functional again.
The three main goals here are:
- Use the configuration models from the "configs" package instead of the
older models in the "config" package, which is now deprecated and
preserved only to help us write our migration tool.
- Do expression inspection and evaluation using the functionality of the
new "lang" package, instead of the Interpolator type and related
functionality in the main "terraform" package.
- Represent addresses of various objects using types in the addrs package,
rather than hand-constructed strings. This is not critical to support
the above, but was a big help during the implementation of these other
points since it made it much more explicit what kind of address is
expected in each context.
Since our new packages are built to accommodate some future planned
features that are not yet implemented (e.g. the "for_each" argument on
resources, "count"/"for_each" on modules), and since there's still a fair
amount of functionality still using old-style APIs, there is a moderate
amount of shimming here to connect new assumptions with old, hopefully in
a way that makes it easier to find and eliminate these shims later.
I apologize in advance to the person who inevitably just found this huge
commit while spelunking through the commit history.
2018-04-30 19:33:53 +02:00
|
|
|
|
|
|
|
"github.com/hashicorp/hcl2/hcl"
|
|
|
|
"github.com/hashicorp/hcl2/hcl/hclsyntax"
|
|
|
|
"github.com/hashicorp/terraform/addrs"
|
|
|
|
"github.com/hashicorp/terraform/tfdiags"
|
2014-07-18 20:37:27 +02:00
|
|
|
)
|
|
|
|
|
core: Allow lists and maps as variable overrides
Terraform 0.7 introduces lists and maps as first-class values for
variables, in addition to string values which were previously available.
However, there was previously no way to override the default value of a
list or map, and the functionality for overriding specific map keys was
broken.
Using the environment variable method for setting variable values, there
was previously no way to give a variable a value of a list or map. These
now support HCL for individual values - specifying:
TF_VAR_test='["Hello", "World"]'
will set the variable `test` to a two-element list containing "Hello"
and "World". Specifying
TF_VAR_test_map='{"Hello = "World", "Foo" = "bar"}'
will set the variable `test_map` to a two-element map with keys "Hello"
and "Foo", and values "World" and "bar" respectively.
The same logic is applied to `-var` flags, and the file parsed by
`-var-files` ("autoVariables").
Note that care must be taken to not run into shell expansion for `-var-`
flags and environment variables.
We also merge map keys where appropriate. The override syntax has
changed (to be noted in CHANGELOG as a breaking change), so several
tests needed their syntax updating from the old `amis.us-east-1 =
"newValue"` style to `amis = "{ "us-east-1" = "newValue"}"` style as
defined in TF-002.
In order to continue supporting the `-var "foo=bar"` type of variable
flag (which is not valid HCL), a special case error is checked after HCL
parsing fails, and the old code path runs instead.
2016-07-21 03:38:26 +02:00
|
|
|
// FlagStringKV is a flag.Value implementation for parsing user variables
|
|
|
|
// from the command-line in the format of '-var key=value', where value is
|
|
|
|
// only ever a primitive.
|
|
|
|
type FlagStringKV map[string]string
|
|
|
|
|
|
|
|
func (v *FlagStringKV) String() string {
|
|
|
|
return ""
|
|
|
|
}
|
|
|
|
|
|
|
|
func (v *FlagStringKV) Set(raw string) error {
|
2014-07-18 20:37:27 +02:00
|
|
|
idx := strings.Index(raw, "=")
|
|
|
|
if idx == -1 {
|
|
|
|
return fmt.Errorf("No '=' value in arg: %s", raw)
|
|
|
|
}
|
|
|
|
|
|
|
|
if *v == nil {
|
|
|
|
*v = make(map[string]string)
|
|
|
|
}
|
|
|
|
|
|
|
|
key, value := raw[0:idx], raw[idx+1:]
|
|
|
|
(*v)[key] = value
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
2015-03-24 17:18:15 +01:00
|
|
|
// FlagStringSlice is a flag.Value implementation for parsing targets from the
|
|
|
|
// command line, e.g. -target=aws_instance.foo -target=aws_vpc.bar
|
|
|
|
type FlagStringSlice []string
|
|
|
|
|
|
|
|
func (v *FlagStringSlice) String() string {
|
|
|
|
return ""
|
|
|
|
}
|
|
|
|
func (v *FlagStringSlice) Set(raw string) error {
|
|
|
|
*v = append(*v, raw)
|
|
|
|
|
|
|
|
return nil
|
|
|
|
}
|
terraform: ugly huge change to weave in new HCL2-oriented types
Due to how deeply the configuration types go into Terraform Core, there
isn't a great way to switch out to HCL2 gradually. As a consequence, this
huge commit gets us from the old state to a _compilable_ new state, but
does not yet attempt to fix any tests and has a number of known missing
parts and bugs. We will continue to iterate on this in forthcoming
commits, heading back towards passing tests and making Terraform
fully-functional again.
The three main goals here are:
- Use the configuration models from the "configs" package instead of the
older models in the "config" package, which is now deprecated and
preserved only to help us write our migration tool.
- Do expression inspection and evaluation using the functionality of the
new "lang" package, instead of the Interpolator type and related
functionality in the main "terraform" package.
- Represent addresses of various objects using types in the addrs package,
rather than hand-constructed strings. This is not critical to support
the above, but was a big help during the implementation of these other
points since it made it much more explicit what kind of address is
expected in each context.
Since our new packages are built to accommodate some future planned
features that are not yet implemented (e.g. the "for_each" argument on
resources, "count"/"for_each" on modules), and since there's still a fair
amount of functionality still using old-style APIs, there is a moderate
amount of shimming here to connect new assumptions with old, hopefully in
a way that makes it easier to find and eliminate these shims later.
I apologize in advance to the person who inevitably just found this huge
commit while spelunking through the commit history.
2018-04-30 19:33:53 +02:00
|
|
|
|
|
|
|
// FlagTargetSlice is a flag.Value implementation for parsing target addresses
|
|
|
|
// from the command line, such as -target=aws_instance.foo -target=aws_vpc.bar .
|
|
|
|
type FlagTargetSlice []addrs.Targetable
|
|
|
|
|
|
|
|
func (v *FlagTargetSlice) String() string {
|
|
|
|
return ""
|
|
|
|
}
|
|
|
|
|
|
|
|
func (v *FlagTargetSlice) Set(raw string) error {
|
|
|
|
// FIXME: This is not an ideal way to deal with this because it requires
|
|
|
|
// us to do parsing in a context where we can't nicely return errors
|
|
|
|
// to the user.
|
|
|
|
|
|
|
|
var diags tfdiags.Diagnostics
|
|
|
|
synthFilename := fmt.Sprintf("-target=%q", raw)
|
|
|
|
traversal, syntaxDiags := hclsyntax.ParseTraversalAbs([]byte(raw), synthFilename, hcl.Pos{Line: 1, Column: 1})
|
|
|
|
diags = diags.Append(syntaxDiags)
|
|
|
|
if syntaxDiags.HasErrors() {
|
|
|
|
return diags.Err()
|
|
|
|
}
|
|
|
|
|
|
|
|
target, targetDiags := addrs.ParseTarget(traversal)
|
|
|
|
diags = diags.Append(targetDiags)
|
|
|
|
if targetDiags.HasErrors() {
|
|
|
|
return diags.Err()
|
|
|
|
}
|
|
|
|
|
|
|
|
*v = append(*v, target.Subject)
|
|
|
|
return nil
|
|
|
|
}
|