2016-05-04 19:32:08 +02:00
|
|
|
package command
|
|
|
|
|
|
|
|
import (
|
2016-11-02 18:30:28 +01:00
|
|
|
"fmt"
|
2017-06-27 17:07:45 +02:00
|
|
|
"io/ioutil"
|
2018-11-17 03:37:26 +01:00
|
|
|
"log"
|
2017-06-27 17:07:45 +02:00
|
|
|
"os"
|
2018-03-20 17:44:12 +01:00
|
|
|
"path/filepath"
|
2017-05-17 03:20:08 +02:00
|
|
|
"strings"
|
2016-05-04 19:32:08 +02:00
|
|
|
"testing"
|
|
|
|
|
2018-09-29 18:45:09 +02:00
|
|
|
"github.com/mitchellh/cli"
|
|
|
|
"github.com/zclconf/go-cty/cty"
|
|
|
|
|
2019-12-04 17:30:20 +01:00
|
|
|
"github.com/hashicorp/terraform/addrs"
|
2018-10-15 01:54:23 +02:00
|
|
|
"github.com/hashicorp/terraform/configs/configschema"
|
2017-06-27 17:07:45 +02:00
|
|
|
"github.com/hashicorp/terraform/helper/copy"
|
|
|
|
"github.com/hashicorp/terraform/plugin/discovery"
|
2018-09-29 18:45:09 +02:00
|
|
|
"github.com/hashicorp/terraform/providers"
|
2016-05-04 19:32:08 +02:00
|
|
|
"github.com/hashicorp/terraform/terraform"
|
2018-09-29 18:45:09 +02:00
|
|
|
"github.com/hashicorp/terraform/tfdiags"
|
2016-05-04 19:32:08 +02:00
|
|
|
)
|
|
|
|
|
|
|
|
func TestImport(t *testing.T) {
|
2017-04-22 02:19:37 +02:00
|
|
|
defer testChdir(t, testFixturePath("import-provider-implicit"))()
|
|
|
|
|
2016-05-04 19:32:08 +02:00
|
|
|
statePath := testTempFile(t)
|
|
|
|
|
|
|
|
p := testProvider()
|
|
|
|
ui := new(cli.MockUi)
|
|
|
|
c := &ImportCommand{
|
|
|
|
Meta: Meta{
|
2017-04-14 03:05:58 +02:00
|
|
|
testingOverrides: metaOverridesForProvider(p),
|
|
|
|
Ui: ui,
|
2016-05-04 19:32:08 +02:00
|
|
|
},
|
|
|
|
}
|
|
|
|
|
2018-09-29 18:45:09 +02:00
|
|
|
p.ImportResourceStateFn = nil
|
|
|
|
p.ImportResourceStateResponse = providers.ImportResourceStateResponse{
|
|
|
|
ImportedResources: []providers.ImportedResource{
|
|
|
|
{
|
|
|
|
TypeName: "test_instance",
|
2018-10-14 16:59:15 +02:00
|
|
|
State: cty.ObjectVal(map[string]cty.Value{
|
2018-09-29 18:45:09 +02:00
|
|
|
"id": cty.StringVal("yay"),
|
|
|
|
}),
|
2016-05-04 19:32:08 +02:00
|
|
|
},
|
|
|
|
},
|
|
|
|
}
|
2018-10-15 01:54:23 +02:00
|
|
|
p.GetSchemaReturn = &terraform.ProviderSchema{
|
|
|
|
ResourceTypes: map[string]*configschema.Block{
|
|
|
|
"test_instance": {
|
|
|
|
Attributes: map[string]*configschema.Attribute{
|
2018-10-15 17:34:42 +02:00
|
|
|
"id": {Type: cty.String, Optional: true, Computed: true},
|
2018-10-15 01:54:23 +02:00
|
|
|
},
|
|
|
|
},
|
|
|
|
},
|
|
|
|
}
|
2016-05-04 19:32:08 +02:00
|
|
|
|
|
|
|
args := []string{
|
|
|
|
"-state", statePath,
|
2016-05-04 19:48:16 +02:00
|
|
|
"test_instance.foo",
|
2016-05-04 19:32:08 +02:00
|
|
|
"bar",
|
|
|
|
}
|
|
|
|
if code := c.Run(args); code != 0 {
|
|
|
|
t.Fatalf("bad: %d\n\n%s", code, ui.ErrorWriter.String())
|
|
|
|
}
|
|
|
|
|
2018-09-29 18:45:09 +02:00
|
|
|
if !p.ImportResourceStateCalled {
|
|
|
|
t.Fatal("ImportResourceState should be called")
|
2016-05-04 19:32:08 +02:00
|
|
|
}
|
|
|
|
|
2016-05-04 19:48:16 +02:00
|
|
|
testStateOutput(t, statePath, testImportStr)
|
2016-05-04 19:32:08 +02:00
|
|
|
}
|
|
|
|
|
2016-11-02 18:30:28 +01:00
|
|
|
func TestImport_providerConfig(t *testing.T) {
|
|
|
|
defer testChdir(t, testFixturePath("import-provider"))()
|
|
|
|
|
|
|
|
statePath := testTempFile(t)
|
|
|
|
|
|
|
|
p := testProvider()
|
|
|
|
ui := new(cli.MockUi)
|
|
|
|
c := &ImportCommand{
|
|
|
|
Meta: Meta{
|
2017-04-14 03:05:58 +02:00
|
|
|
testingOverrides: metaOverridesForProvider(p),
|
|
|
|
Ui: ui,
|
2016-11-02 18:30:28 +01:00
|
|
|
},
|
|
|
|
}
|
|
|
|
|
2018-09-29 18:45:09 +02:00
|
|
|
p.ImportResourceStateFn = nil
|
|
|
|
p.ImportResourceStateResponse = providers.ImportResourceStateResponse{
|
|
|
|
ImportedResources: []providers.ImportedResource{
|
|
|
|
{
|
|
|
|
TypeName: "test_instance",
|
2018-10-14 16:59:15 +02:00
|
|
|
State: cty.ObjectVal(map[string]cty.Value{
|
2018-09-29 18:45:09 +02:00
|
|
|
"id": cty.StringVal("yay"),
|
|
|
|
}),
|
2016-11-02 18:30:28 +01:00
|
|
|
},
|
|
|
|
},
|
|
|
|
}
|
2018-10-15 01:54:23 +02:00
|
|
|
p.GetSchemaReturn = &terraform.ProviderSchema{
|
|
|
|
Provider: &configschema.Block{
|
|
|
|
Attributes: map[string]*configschema.Attribute{
|
2018-10-15 17:34:42 +02:00
|
|
|
"foo": {Type: cty.String, Optional: true},
|
2018-10-15 01:54:23 +02:00
|
|
|
},
|
|
|
|
},
|
|
|
|
ResourceTypes: map[string]*configschema.Block{
|
|
|
|
"test_instance": {
|
|
|
|
Attributes: map[string]*configschema.Attribute{
|
2018-10-15 17:34:42 +02:00
|
|
|
"id": {Type: cty.String, Optional: true, Computed: true},
|
2018-10-15 01:54:23 +02:00
|
|
|
},
|
|
|
|
},
|
|
|
|
},
|
|
|
|
}
|
2016-11-02 18:30:28 +01:00
|
|
|
|
|
|
|
configured := false
|
2018-09-29 18:45:09 +02:00
|
|
|
p.ConfigureNewFn = func(req providers.ConfigureRequest) providers.ConfigureResponse {
|
2016-11-02 18:30:28 +01:00
|
|
|
configured = true
|
|
|
|
|
2018-09-29 18:45:09 +02:00
|
|
|
cfg := req.Config
|
|
|
|
if !cfg.Type().HasAttribute("foo") {
|
|
|
|
return providers.ConfigureResponse{
|
|
|
|
Diagnostics: tfdiags.Diagnostics{}.Append(fmt.Errorf("configuration has no foo argument")),
|
|
|
|
}
|
|
|
|
}
|
|
|
|
if got, want := cfg.GetAttr("foo"), cty.StringVal("bar"); !want.RawEquals(got) {
|
|
|
|
return providers.ConfigureResponse{
|
|
|
|
Diagnostics: tfdiags.Diagnostics{}.Append(fmt.Errorf("foo argument is %#v, but want %#v", got, want)),
|
|
|
|
}
|
2016-11-02 18:30:28 +01:00
|
|
|
}
|
|
|
|
|
2018-09-29 18:45:09 +02:00
|
|
|
return providers.ConfigureResponse{}
|
2016-11-02 18:30:28 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
args := []string{
|
|
|
|
"-state", statePath,
|
|
|
|
"test_instance.foo",
|
|
|
|
"bar",
|
|
|
|
}
|
|
|
|
if code := c.Run(args); code != 0 {
|
|
|
|
t.Fatalf("bad: %d\n\n%s", code, ui.ErrorWriter.String())
|
|
|
|
}
|
2016-11-02 19:11:42 +01:00
|
|
|
|
|
|
|
// Verify that we were called
|
|
|
|
if !configured {
|
|
|
|
t.Fatal("Configure should be called")
|
|
|
|
}
|
|
|
|
|
2018-09-29 18:45:09 +02:00
|
|
|
if !p.ImportResourceStateCalled {
|
|
|
|
t.Fatal("ImportResourceState should be called")
|
2016-11-02 19:11:42 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
testStateOutput(t, statePath, testImportStr)
|
|
|
|
}
|
|
|
|
|
2017-08-09 00:41:00 +02:00
|
|
|
// "remote" state provided by the "local" backend
|
|
|
|
func TestImport_remoteState(t *testing.T) {
|
|
|
|
td := tempDir(t)
|
|
|
|
copy.CopyDir(testFixturePath("import-provider-remote-state"), td)
|
|
|
|
defer os.RemoveAll(td)
|
|
|
|
defer testChdir(t, td)()
|
|
|
|
|
|
|
|
statePath := "imported.tfstate"
|
|
|
|
|
|
|
|
// init our backend
|
2018-11-15 22:31:30 +01:00
|
|
|
ui := cli.NewMockUi()
|
2017-08-09 00:41:00 +02:00
|
|
|
m := Meta{
|
|
|
|
testingOverrides: metaOverridesForProvider(testProvider()),
|
|
|
|
Ui: ui,
|
|
|
|
}
|
|
|
|
|
|
|
|
ic := &InitCommand{
|
|
|
|
Meta: m,
|
|
|
|
providerInstaller: &mockProviderInstaller{
|
|
|
|
Providers: map[string][]string{
|
|
|
|
"test": []string{"1.2.3"},
|
|
|
|
},
|
|
|
|
|
|
|
|
Dir: m.pluginDir(),
|
|
|
|
},
|
|
|
|
}
|
|
|
|
|
2018-11-15 22:31:30 +01:00
|
|
|
// (Using log here rather than t.Log so that these messages interleave with other trace logs)
|
|
|
|
log.Print("[TRACE] TestImport_remoteState running: terraform init")
|
2017-08-09 00:41:00 +02:00
|
|
|
if code := ic.Run([]string{}); code != 0 {
|
2018-11-15 22:31:30 +01:00
|
|
|
t.Fatalf("init failed\n%s", ui.ErrorWriter)
|
2017-08-09 00:41:00 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
p := testProvider()
|
|
|
|
ui = new(cli.MockUi)
|
|
|
|
c := &ImportCommand{
|
|
|
|
Meta: Meta{
|
|
|
|
testingOverrides: metaOverridesForProvider(p),
|
|
|
|
Ui: ui,
|
|
|
|
},
|
|
|
|
}
|
|
|
|
|
2018-09-29 18:45:09 +02:00
|
|
|
p.ImportResourceStateFn = nil
|
|
|
|
p.ImportResourceStateResponse = providers.ImportResourceStateResponse{
|
|
|
|
ImportedResources: []providers.ImportedResource{
|
|
|
|
{
|
|
|
|
TypeName: "test_instance",
|
2018-10-14 16:59:15 +02:00
|
|
|
State: cty.ObjectVal(map[string]cty.Value{
|
2018-09-29 18:45:09 +02:00
|
|
|
"id": cty.StringVal("yay"),
|
|
|
|
}),
|
2017-08-09 00:41:00 +02:00
|
|
|
},
|
|
|
|
},
|
|
|
|
}
|
2018-10-15 01:54:23 +02:00
|
|
|
p.GetSchemaReturn = &terraform.ProviderSchema{
|
|
|
|
Provider: &configschema.Block{
|
|
|
|
Attributes: map[string]*configschema.Attribute{
|
2018-10-15 17:34:42 +02:00
|
|
|
"foo": {Type: cty.String, Optional: true},
|
2018-10-15 01:54:23 +02:00
|
|
|
},
|
|
|
|
},
|
|
|
|
ResourceTypes: map[string]*configschema.Block{
|
|
|
|
"test_instance": {
|
|
|
|
Attributes: map[string]*configschema.Attribute{
|
2018-10-15 17:34:42 +02:00
|
|
|
"id": {Type: cty.String, Optional: true, Computed: true},
|
2018-10-15 01:54:23 +02:00
|
|
|
},
|
|
|
|
},
|
|
|
|
},
|
|
|
|
}
|
2017-08-09 00:41:00 +02:00
|
|
|
|
|
|
|
configured := false
|
2018-10-15 01:54:23 +02:00
|
|
|
p.ConfigureNewFn = func(req providers.ConfigureRequest) providers.ConfigureResponse {
|
|
|
|
var diags tfdiags.Diagnostics
|
2017-08-09 00:41:00 +02:00
|
|
|
configured = true
|
2018-10-15 01:54:23 +02:00
|
|
|
if got, want := req.Config.GetAttr("foo"), cty.StringVal("bar"); !want.RawEquals(got) {
|
|
|
|
diags = diags.Append(fmt.Errorf("wrong \"foo\" value %#v; want %#v", got, want))
|
|
|
|
}
|
|
|
|
return providers.ConfigureResponse{
|
|
|
|
Diagnostics: diags,
|
2017-08-09 00:41:00 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
args := []string{
|
|
|
|
"test_instance.foo",
|
|
|
|
"bar",
|
|
|
|
}
|
2018-11-15 22:31:30 +01:00
|
|
|
log.Printf("[TRACE] TestImport_remoteState running: terraform import %s %s", args[0], args[1])
|
2017-08-09 00:41:00 +02:00
|
|
|
if code := c.Run(args); code != 0 {
|
|
|
|
fmt.Println(ui.OutputWriter)
|
|
|
|
t.Fatalf("bad: %d\n\n%s", code, ui.ErrorWriter.String())
|
|
|
|
}
|
|
|
|
|
2018-03-20 17:44:12 +01:00
|
|
|
// verify that the local state was unlocked after import
|
|
|
|
if _, err := os.Stat(filepath.Join(td, fmt.Sprintf(".%s.lock.info", statePath))); !os.IsNotExist(err) {
|
|
|
|
t.Fatal("state left locked after import")
|
|
|
|
}
|
|
|
|
|
2017-08-09 00:41:00 +02:00
|
|
|
// Verify that we were called
|
|
|
|
if !configured {
|
|
|
|
t.Fatal("Configure should be called")
|
|
|
|
}
|
|
|
|
|
2018-09-29 18:45:09 +02:00
|
|
|
if !p.ImportResourceStateCalled {
|
|
|
|
t.Fatal("ImportResourceState should be called")
|
2017-08-09 00:41:00 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
testStateOutput(t, statePath, testImportStr)
|
|
|
|
}
|
|
|
|
|
2017-01-24 22:01:23 +01:00
|
|
|
func TestImport_providerConfigWithVar(t *testing.T) {
|
|
|
|
defer testChdir(t, testFixturePath("import-provider-var"))()
|
|
|
|
|
|
|
|
statePath := testTempFile(t)
|
|
|
|
|
|
|
|
p := testProvider()
|
|
|
|
ui := new(cli.MockUi)
|
|
|
|
c := &ImportCommand{
|
|
|
|
Meta: Meta{
|
2017-04-14 03:05:58 +02:00
|
|
|
testingOverrides: metaOverridesForProvider(p),
|
|
|
|
Ui: ui,
|
2017-01-24 22:01:23 +01:00
|
|
|
},
|
|
|
|
}
|
|
|
|
|
2018-09-29 18:45:09 +02:00
|
|
|
p.ImportResourceStateFn = nil
|
|
|
|
p.ImportResourceStateResponse = providers.ImportResourceStateResponse{
|
|
|
|
ImportedResources: []providers.ImportedResource{
|
|
|
|
{
|
|
|
|
TypeName: "test_instance",
|
2018-10-14 16:59:15 +02:00
|
|
|
State: cty.ObjectVal(map[string]cty.Value{
|
2018-09-29 18:45:09 +02:00
|
|
|
"id": cty.StringVal("yay"),
|
|
|
|
}),
|
2017-01-24 22:01:23 +01:00
|
|
|
},
|
|
|
|
},
|
|
|
|
}
|
2018-10-15 01:54:23 +02:00
|
|
|
p.GetSchemaReturn = &terraform.ProviderSchema{
|
|
|
|
Provider: &configschema.Block{
|
|
|
|
Attributes: map[string]*configschema.Attribute{
|
2018-10-15 17:34:42 +02:00
|
|
|
"foo": {Type: cty.String, Optional: true},
|
2018-10-15 01:54:23 +02:00
|
|
|
},
|
|
|
|
},
|
|
|
|
ResourceTypes: map[string]*configschema.Block{
|
|
|
|
"test_instance": {
|
|
|
|
Attributes: map[string]*configschema.Attribute{
|
2018-10-15 17:34:42 +02:00
|
|
|
"id": {Type: cty.String, Optional: true, Computed: true},
|
2018-10-15 01:54:23 +02:00
|
|
|
},
|
|
|
|
},
|
|
|
|
},
|
|
|
|
}
|
2017-01-24 22:01:23 +01:00
|
|
|
|
|
|
|
configured := false
|
2018-10-15 01:54:23 +02:00
|
|
|
p.ConfigureNewFn = func(req providers.ConfigureRequest) providers.ConfigureResponse {
|
|
|
|
var diags tfdiags.Diagnostics
|
2017-01-24 22:01:23 +01:00
|
|
|
configured = true
|
2018-10-15 01:54:23 +02:00
|
|
|
if got, want := req.Config.GetAttr("foo"), cty.StringVal("bar"); !want.RawEquals(got) {
|
|
|
|
diags = diags.Append(fmt.Errorf("wrong \"foo\" value %#v; want %#v", got, want))
|
|
|
|
}
|
|
|
|
return providers.ConfigureResponse{
|
|
|
|
Diagnostics: diags,
|
2017-01-24 22:01:23 +01:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
args := []string{
|
|
|
|
"-state", statePath,
|
|
|
|
"-var", "foo=bar",
|
|
|
|
"test_instance.foo",
|
|
|
|
"bar",
|
|
|
|
}
|
|
|
|
if code := c.Run(args); code != 0 {
|
|
|
|
t.Fatalf("bad: %d\n\n%s", code, ui.ErrorWriter.String())
|
|
|
|
}
|
|
|
|
|
|
|
|
// Verify that we were called
|
|
|
|
if !configured {
|
|
|
|
t.Fatal("Configure should be called")
|
|
|
|
}
|
|
|
|
|
2018-09-29 18:45:09 +02:00
|
|
|
if !p.ImportResourceStateCalled {
|
|
|
|
t.Fatal("ImportResourceState should be called")
|
2017-01-24 22:01:23 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
testStateOutput(t, statePath, testImportStr)
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestImport_providerConfigWithVarDefault(t *testing.T) {
|
|
|
|
defer testChdir(t, testFixturePath("import-provider-var-default"))()
|
|
|
|
|
|
|
|
statePath := testTempFile(t)
|
|
|
|
|
|
|
|
p := testProvider()
|
|
|
|
ui := new(cli.MockUi)
|
|
|
|
c := &ImportCommand{
|
|
|
|
Meta: Meta{
|
2017-04-14 03:05:58 +02:00
|
|
|
testingOverrides: metaOverridesForProvider(p),
|
|
|
|
Ui: ui,
|
2017-01-24 22:01:23 +01:00
|
|
|
},
|
|
|
|
}
|
|
|
|
|
2018-09-29 18:45:09 +02:00
|
|
|
p.ImportResourceStateFn = nil
|
|
|
|
p.ImportResourceStateResponse = providers.ImportResourceStateResponse{
|
|
|
|
ImportedResources: []providers.ImportedResource{
|
|
|
|
{
|
|
|
|
TypeName: "test_instance",
|
2018-10-14 16:59:15 +02:00
|
|
|
State: cty.ObjectVal(map[string]cty.Value{
|
2018-09-29 18:45:09 +02:00
|
|
|
"id": cty.StringVal("yay"),
|
|
|
|
}),
|
2017-01-24 22:01:23 +01:00
|
|
|
},
|
|
|
|
},
|
|
|
|
}
|
2018-10-15 01:54:23 +02:00
|
|
|
p.GetSchemaReturn = &terraform.ProviderSchema{
|
|
|
|
Provider: &configschema.Block{
|
|
|
|
Attributes: map[string]*configschema.Attribute{
|
2018-10-15 17:34:42 +02:00
|
|
|
"foo": {Type: cty.String, Optional: true},
|
2018-10-15 01:54:23 +02:00
|
|
|
},
|
|
|
|
},
|
|
|
|
ResourceTypes: map[string]*configschema.Block{
|
|
|
|
"test_instance": {
|
|
|
|
Attributes: map[string]*configschema.Attribute{
|
2018-10-15 17:34:42 +02:00
|
|
|
"id": {Type: cty.String, Optional: true, Computed: true},
|
2018-10-15 01:54:23 +02:00
|
|
|
},
|
|
|
|
},
|
|
|
|
},
|
|
|
|
}
|
2017-01-24 22:01:23 +01:00
|
|
|
|
|
|
|
configured := false
|
2018-10-15 01:54:23 +02:00
|
|
|
p.ConfigureNewFn = func(req providers.ConfigureRequest) providers.ConfigureResponse {
|
|
|
|
var diags tfdiags.Diagnostics
|
2017-01-24 22:01:23 +01:00
|
|
|
configured = true
|
2018-10-15 01:54:23 +02:00
|
|
|
if got, want := req.Config.GetAttr("foo"), cty.StringVal("bar"); !want.RawEquals(got) {
|
|
|
|
diags = diags.Append(fmt.Errorf("wrong \"foo\" value %#v; want %#v", got, want))
|
|
|
|
}
|
|
|
|
return providers.ConfigureResponse{
|
|
|
|
Diagnostics: diags,
|
2017-01-24 22:01:23 +01:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
args := []string{
|
|
|
|
"-state", statePath,
|
|
|
|
"test_instance.foo",
|
|
|
|
"bar",
|
|
|
|
}
|
|
|
|
if code := c.Run(args); code != 0 {
|
|
|
|
t.Fatalf("bad: %d\n\n%s", code, ui.ErrorWriter.String())
|
|
|
|
}
|
|
|
|
|
|
|
|
// Verify that we were called
|
|
|
|
if !configured {
|
|
|
|
t.Fatal("Configure should be called")
|
|
|
|
}
|
|
|
|
|
2018-09-29 18:45:09 +02:00
|
|
|
if !p.ImportResourceStateCalled {
|
|
|
|
t.Fatal("ImportResourceState should be called")
|
2017-01-24 22:01:23 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
testStateOutput(t, statePath, testImportStr)
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestImport_providerConfigWithVarFile(t *testing.T) {
|
|
|
|
defer testChdir(t, testFixturePath("import-provider-var-file"))()
|
|
|
|
|
|
|
|
statePath := testTempFile(t)
|
|
|
|
|
|
|
|
p := testProvider()
|
|
|
|
ui := new(cli.MockUi)
|
|
|
|
c := &ImportCommand{
|
|
|
|
Meta: Meta{
|
2017-04-14 03:05:58 +02:00
|
|
|
testingOverrides: metaOverridesForProvider(p),
|
|
|
|
Ui: ui,
|
2017-01-24 22:01:23 +01:00
|
|
|
},
|
|
|
|
}
|
|
|
|
|
2018-09-29 18:45:09 +02:00
|
|
|
p.ImportResourceStateFn = nil
|
|
|
|
p.ImportResourceStateResponse = providers.ImportResourceStateResponse{
|
|
|
|
ImportedResources: []providers.ImportedResource{
|
|
|
|
{
|
|
|
|
TypeName: "test_instance",
|
2018-10-14 16:59:15 +02:00
|
|
|
State: cty.ObjectVal(map[string]cty.Value{
|
2018-09-29 18:45:09 +02:00
|
|
|
"id": cty.StringVal("yay"),
|
|
|
|
}),
|
2017-01-24 22:01:23 +01:00
|
|
|
},
|
|
|
|
},
|
|
|
|
}
|
2018-10-15 01:54:23 +02:00
|
|
|
p.GetSchemaReturn = &terraform.ProviderSchema{
|
|
|
|
Provider: &configschema.Block{
|
|
|
|
Attributes: map[string]*configschema.Attribute{
|
2018-10-15 17:34:42 +02:00
|
|
|
"foo": {Type: cty.String, Optional: true},
|
2018-10-15 01:54:23 +02:00
|
|
|
},
|
|
|
|
},
|
|
|
|
ResourceTypes: map[string]*configschema.Block{
|
|
|
|
"test_instance": {
|
|
|
|
Attributes: map[string]*configschema.Attribute{
|
2018-10-15 17:34:42 +02:00
|
|
|
"id": {Type: cty.String, Optional: true, Computed: true},
|
2018-10-15 01:54:23 +02:00
|
|
|
},
|
|
|
|
},
|
|
|
|
},
|
|
|
|
}
|
2017-01-24 22:01:23 +01:00
|
|
|
|
|
|
|
configured := false
|
2018-10-15 01:54:23 +02:00
|
|
|
p.ConfigureNewFn = func(req providers.ConfigureRequest) providers.ConfigureResponse {
|
|
|
|
var diags tfdiags.Diagnostics
|
2017-01-24 22:01:23 +01:00
|
|
|
configured = true
|
2018-10-15 01:54:23 +02:00
|
|
|
if got, want := req.Config.GetAttr("foo"), cty.StringVal("bar"); !want.RawEquals(got) {
|
|
|
|
diags = diags.Append(fmt.Errorf("wrong \"foo\" value %#v; want %#v", got, want))
|
|
|
|
}
|
|
|
|
return providers.ConfigureResponse{
|
|
|
|
Diagnostics: diags,
|
2017-01-24 22:01:23 +01:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
args := []string{
|
|
|
|
"-state", statePath,
|
|
|
|
"-var-file", "blah.tfvars",
|
|
|
|
"test_instance.foo",
|
|
|
|
"bar",
|
|
|
|
}
|
|
|
|
if code := c.Run(args); code != 0 {
|
|
|
|
t.Fatalf("bad: %d\n\n%s", code, ui.ErrorWriter.String())
|
|
|
|
}
|
|
|
|
|
|
|
|
// Verify that we were called
|
|
|
|
if !configured {
|
|
|
|
t.Fatal("Configure should be called")
|
|
|
|
}
|
|
|
|
|
2018-09-29 18:45:09 +02:00
|
|
|
if !p.ImportResourceStateCalled {
|
|
|
|
t.Fatal("ImportResourceState should be called")
|
2017-01-24 22:01:23 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
testStateOutput(t, statePath, testImportStr)
|
|
|
|
}
|
|
|
|
|
2016-11-23 10:44:52 +01:00
|
|
|
func TestImport_customProvider(t *testing.T) {
|
2017-04-22 02:19:37 +02:00
|
|
|
defer testChdir(t, testFixturePath("import-provider-aliased"))()
|
|
|
|
|
2016-11-23 10:44:52 +01:00
|
|
|
statePath := testTempFile(t)
|
|
|
|
|
|
|
|
p := testProvider()
|
|
|
|
ui := new(cli.MockUi)
|
|
|
|
c := &ImportCommand{
|
|
|
|
Meta: Meta{
|
2017-04-14 03:05:58 +02:00
|
|
|
testingOverrides: metaOverridesForProvider(p),
|
|
|
|
Ui: ui,
|
2016-11-23 10:44:52 +01:00
|
|
|
},
|
|
|
|
}
|
|
|
|
|
2018-09-29 18:45:09 +02:00
|
|
|
p.ImportResourceStateFn = nil
|
|
|
|
p.ImportResourceStateResponse = providers.ImportResourceStateResponse{
|
|
|
|
ImportedResources: []providers.ImportedResource{
|
|
|
|
{
|
|
|
|
TypeName: "test_instance",
|
2018-10-14 16:59:15 +02:00
|
|
|
State: cty.ObjectVal(map[string]cty.Value{
|
2018-09-29 18:45:09 +02:00
|
|
|
"id": cty.StringVal("yay"),
|
|
|
|
}),
|
2016-11-23 10:44:52 +01:00
|
|
|
},
|
|
|
|
},
|
|
|
|
}
|
2018-10-15 01:54:23 +02:00
|
|
|
p.GetSchemaReturn = &terraform.ProviderSchema{
|
|
|
|
Provider: &configschema.Block{
|
|
|
|
Attributes: map[string]*configschema.Attribute{
|
2018-10-15 17:34:42 +02:00
|
|
|
"foo": {Type: cty.String, Optional: true},
|
2018-10-15 01:54:23 +02:00
|
|
|
},
|
|
|
|
},
|
|
|
|
ResourceTypes: map[string]*configschema.Block{
|
|
|
|
"test_instance": {
|
|
|
|
Attributes: map[string]*configschema.Attribute{
|
2018-10-15 17:34:42 +02:00
|
|
|
"id": {Type: cty.String, Optional: true, Computed: true},
|
2018-10-15 01:54:23 +02:00
|
|
|
},
|
|
|
|
},
|
|
|
|
},
|
|
|
|
}
|
2016-11-23 10:44:52 +01:00
|
|
|
|
|
|
|
args := []string{
|
|
|
|
"-provider", "test.alias",
|
|
|
|
"-state", statePath,
|
|
|
|
"test_instance.foo",
|
|
|
|
"bar",
|
|
|
|
}
|
|
|
|
if code := c.Run(args); code != 0 {
|
|
|
|
t.Fatalf("bad: %d\n\n%s", code, ui.ErrorWriter.String())
|
|
|
|
}
|
|
|
|
|
2018-09-29 18:45:09 +02:00
|
|
|
if !p.ImportResourceStateCalled {
|
|
|
|
t.Fatal("ImportResourceState should be called")
|
2016-11-23 10:44:52 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
testStateOutput(t, statePath, testImportCustomProviderStr)
|
|
|
|
}
|
|
|
|
|
2019-09-20 16:02:42 +02:00
|
|
|
// This tests behavior when the provider name does not match the implied
|
|
|
|
// provider name
|
|
|
|
func TestImport_providerNameMismatch(t *testing.T) {
|
|
|
|
defer testChdir(t, testFixturePath("import-provider-mismatch"))()
|
|
|
|
|
|
|
|
statePath := testTempFile(t)
|
|
|
|
|
|
|
|
p := testProvider()
|
|
|
|
ui := new(cli.MockUi)
|
|
|
|
c := &ImportCommand{
|
|
|
|
Meta: Meta{
|
|
|
|
testingOverrides: &testingOverrides{
|
|
|
|
ProviderResolver: providers.ResolverFixed(
|
2019-12-04 17:30:20 +01:00
|
|
|
map[addrs.Provider]providers.Factory{
|
|
|
|
addrs.NewLegacyProvider("test-beta"): providers.FactoryFixed(p),
|
2019-09-20 16:02:42 +02:00
|
|
|
},
|
|
|
|
),
|
|
|
|
},
|
|
|
|
Ui: ui,
|
|
|
|
},
|
|
|
|
}
|
|
|
|
|
|
|
|
configured := false
|
|
|
|
p.ConfigureNewFn = func(req providers.ConfigureRequest) providers.ConfigureResponse {
|
|
|
|
configured = true
|
|
|
|
|
|
|
|
cfg := req.Config
|
|
|
|
if !cfg.Type().HasAttribute("foo") {
|
|
|
|
return providers.ConfigureResponse{
|
|
|
|
Diagnostics: tfdiags.Diagnostics{}.Append(fmt.Errorf("configuration has no foo argument")),
|
|
|
|
}
|
|
|
|
}
|
|
|
|
if got, want := cfg.GetAttr("foo"), cty.StringVal("baz"); !want.RawEquals(got) {
|
|
|
|
return providers.ConfigureResponse{
|
|
|
|
Diagnostics: tfdiags.Diagnostics{}.Append(fmt.Errorf("foo argument is %#v, but want %#v", got, want)),
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return providers.ConfigureResponse{}
|
|
|
|
}
|
|
|
|
|
|
|
|
p.ImportResourceStateFn = nil
|
|
|
|
p.ImportResourceStateResponse = providers.ImportResourceStateResponse{
|
|
|
|
ImportedResources: []providers.ImportedResource{
|
|
|
|
{
|
|
|
|
TypeName: "test_instance",
|
|
|
|
State: cty.ObjectVal(map[string]cty.Value{
|
|
|
|
"id": cty.StringVal("yay"),
|
|
|
|
}),
|
|
|
|
},
|
|
|
|
},
|
|
|
|
}
|
|
|
|
p.GetSchemaReturn = &terraform.ProviderSchema{
|
|
|
|
Provider: &configschema.Block{
|
|
|
|
Attributes: map[string]*configschema.Attribute{
|
|
|
|
"foo": {Type: cty.String, Optional: true},
|
|
|
|
},
|
|
|
|
},
|
|
|
|
ResourceTypes: map[string]*configschema.Block{
|
|
|
|
"test_instance": {
|
|
|
|
Attributes: map[string]*configschema.Attribute{
|
|
|
|
"id": {Type: cty.String, Optional: true, Computed: true},
|
|
|
|
},
|
|
|
|
},
|
|
|
|
},
|
|
|
|
}
|
|
|
|
|
|
|
|
args := []string{
|
|
|
|
"-provider", "test-beta",
|
|
|
|
"-state", statePath,
|
|
|
|
"test_instance.foo",
|
|
|
|
"bar",
|
|
|
|
}
|
|
|
|
|
|
|
|
if code := c.Run(args); code != 0 {
|
|
|
|
t.Fatalf("bad: %d\n\n%s", code, ui.ErrorWriter.String())
|
|
|
|
}
|
|
|
|
|
|
|
|
// Verify that the test-beta provider was configured
|
|
|
|
if !configured {
|
|
|
|
t.Fatal("Configure should be called")
|
|
|
|
}
|
|
|
|
|
|
|
|
if !p.ImportResourceStateCalled {
|
|
|
|
t.Fatal("ImportResourceState (provider 'test-beta') should be called")
|
|
|
|
}
|
|
|
|
|
|
|
|
if !p.ReadResourceCalled {
|
|
|
|
t.Fatal("ReadResource (provider 'test-beta' should be called")
|
|
|
|
}
|
|
|
|
|
|
|
|
testStateOutput(t, statePath, testImportProviderMismatchStr)
|
|
|
|
}
|
2017-09-18 20:41:30 +02:00
|
|
|
func TestImport_allowMissingResourceConfig(t *testing.T) {
|
|
|
|
defer testChdir(t, testFixturePath("import-missing-resource-config"))()
|
|
|
|
|
|
|
|
statePath := testTempFile(t)
|
|
|
|
|
|
|
|
p := testProvider()
|
|
|
|
ui := new(cli.MockUi)
|
|
|
|
c := &ImportCommand{
|
|
|
|
Meta: Meta{
|
|
|
|
testingOverrides: metaOverridesForProvider(p),
|
|
|
|
Ui: ui,
|
|
|
|
},
|
|
|
|
}
|
|
|
|
|
2018-09-29 18:45:09 +02:00
|
|
|
p.ImportResourceStateFn = nil
|
|
|
|
p.ImportResourceStateResponse = providers.ImportResourceStateResponse{
|
|
|
|
ImportedResources: []providers.ImportedResource{
|
|
|
|
{
|
|
|
|
TypeName: "test_instance",
|
2018-10-14 16:59:15 +02:00
|
|
|
State: cty.ObjectVal(map[string]cty.Value{
|
2018-09-29 18:45:09 +02:00
|
|
|
"id": cty.StringVal("yay"),
|
|
|
|
}),
|
2017-09-18 20:41:30 +02:00
|
|
|
},
|
|
|
|
},
|
|
|
|
}
|
2018-10-15 01:54:23 +02:00
|
|
|
p.GetSchemaReturn = &terraform.ProviderSchema{
|
|
|
|
ResourceTypes: map[string]*configschema.Block{
|
|
|
|
"test_instance": {
|
|
|
|
Attributes: map[string]*configschema.Attribute{
|
2018-10-15 17:34:42 +02:00
|
|
|
"id": {Type: cty.String, Optional: true, Computed: true},
|
2018-10-15 01:54:23 +02:00
|
|
|
},
|
|
|
|
},
|
|
|
|
},
|
|
|
|
}
|
2017-09-18 20:41:30 +02:00
|
|
|
|
|
|
|
args := []string{
|
|
|
|
"-state", statePath,
|
|
|
|
"-allow-missing-config",
|
|
|
|
"test_instance.foo",
|
|
|
|
"bar",
|
|
|
|
}
|
|
|
|
if code := c.Run(args); code != 0 {
|
|
|
|
t.Fatalf("bad: %d\n\n%s", code, ui.ErrorWriter.String())
|
|
|
|
}
|
|
|
|
|
2018-09-29 18:45:09 +02:00
|
|
|
if !p.ImportResourceStateCalled {
|
|
|
|
t.Fatal("ImportResourceState should be called")
|
2017-09-18 20:41:30 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
testStateOutput(t, statePath, testImportStr)
|
|
|
|
}
|
|
|
|
|
2017-12-08 19:22:07 +01:00
|
|
|
func TestImport_emptyConfig(t *testing.T) {
|
|
|
|
defer testChdir(t, testFixturePath("empty"))()
|
|
|
|
|
|
|
|
statePath := testTempFile(t)
|
|
|
|
|
|
|
|
p := testProvider()
|
|
|
|
ui := new(cli.MockUi)
|
|
|
|
c := &ImportCommand{
|
|
|
|
Meta: Meta{
|
|
|
|
testingOverrides: metaOverridesForProvider(p),
|
|
|
|
Ui: ui,
|
|
|
|
},
|
|
|
|
}
|
|
|
|
|
|
|
|
args := []string{
|
|
|
|
"-state", statePath,
|
|
|
|
"test_instance.foo",
|
|
|
|
"bar",
|
|
|
|
}
|
|
|
|
code := c.Run(args)
|
|
|
|
if code != 1 {
|
|
|
|
t.Fatalf("import succeeded; expected failure")
|
|
|
|
}
|
|
|
|
|
|
|
|
msg := ui.ErrorWriter.String()
|
|
|
|
if want := `No Terraform configuration files`; !strings.Contains(msg, want) {
|
|
|
|
t.Errorf("incorrect message\nwant substring: %s\ngot:\n%s", want, msg)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2017-05-17 03:26:20 +02:00
|
|
|
func TestImport_missingResourceConfig(t *testing.T) {
|
|
|
|
defer testChdir(t, testFixturePath("import-missing-resource-config"))()
|
|
|
|
|
|
|
|
statePath := testTempFile(t)
|
|
|
|
|
|
|
|
p := testProvider()
|
|
|
|
ui := new(cli.MockUi)
|
|
|
|
c := &ImportCommand{
|
|
|
|
Meta: Meta{
|
|
|
|
testingOverrides: metaOverridesForProvider(p),
|
|
|
|
Ui: ui,
|
|
|
|
},
|
|
|
|
}
|
|
|
|
|
|
|
|
args := []string{
|
|
|
|
"-state", statePath,
|
|
|
|
"test_instance.foo",
|
|
|
|
"bar",
|
|
|
|
}
|
|
|
|
code := c.Run(args)
|
|
|
|
if code != 1 {
|
|
|
|
t.Fatalf("import succeeded; expected failure")
|
|
|
|
}
|
|
|
|
|
|
|
|
msg := ui.ErrorWriter.String()
|
|
|
|
if want := `resource address "test_instance.foo" does not exist`; !strings.Contains(msg, want) {
|
|
|
|
t.Errorf("incorrect message\nwant substring: %s\ngot:\n%s", want, msg)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestImport_missingModuleConfig(t *testing.T) {
|
|
|
|
defer testChdir(t, testFixturePath("import-missing-resource-config"))()
|
|
|
|
|
|
|
|
statePath := testTempFile(t)
|
|
|
|
|
|
|
|
p := testProvider()
|
|
|
|
ui := new(cli.MockUi)
|
|
|
|
c := &ImportCommand{
|
|
|
|
Meta: Meta{
|
|
|
|
testingOverrides: metaOverridesForProvider(p),
|
|
|
|
Ui: ui,
|
|
|
|
},
|
|
|
|
}
|
|
|
|
|
|
|
|
args := []string{
|
|
|
|
"-state", statePath,
|
|
|
|
"module.baz.test_instance.foo",
|
|
|
|
"bar",
|
|
|
|
}
|
|
|
|
code := c.Run(args)
|
|
|
|
if code != 1 {
|
|
|
|
t.Fatalf("import succeeded; expected failure")
|
|
|
|
}
|
|
|
|
|
|
|
|
msg := ui.ErrorWriter.String()
|
2017-12-08 19:22:07 +01:00
|
|
|
if want := `module.baz is not defined in the configuration`; !strings.Contains(msg, want) {
|
2017-05-17 03:26:20 +02:00
|
|
|
t.Errorf("incorrect message\nwant substring: %s\ngot:\n%s", want, msg)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2017-05-17 03:20:08 +02:00
|
|
|
func TestImport_dataResource(t *testing.T) {
|
|
|
|
defer testChdir(t, testFixturePath("import-missing-resource-config"))()
|
|
|
|
|
|
|
|
statePath := testTempFile(t)
|
|
|
|
|
|
|
|
p := testProvider()
|
|
|
|
ui := new(cli.MockUi)
|
|
|
|
c := &ImportCommand{
|
|
|
|
Meta: Meta{
|
|
|
|
testingOverrides: metaOverridesForProvider(p),
|
|
|
|
Ui: ui,
|
|
|
|
},
|
|
|
|
}
|
|
|
|
|
|
|
|
args := []string{
|
|
|
|
"-state", statePath,
|
|
|
|
"data.test_data_source.foo",
|
|
|
|
"bar",
|
|
|
|
}
|
|
|
|
code := c.Run(args)
|
|
|
|
if code != 1 {
|
|
|
|
t.Fatalf("import succeeded; expected failure")
|
|
|
|
}
|
|
|
|
|
|
|
|
msg := ui.ErrorWriter.String()
|
2018-10-10 02:47:53 +02:00
|
|
|
if want := `A managed resource address is required`; !strings.Contains(msg, want) {
|
2017-05-17 03:20:08 +02:00
|
|
|
t.Errorf("incorrect message\nwant substring: %s\ngot:\n%s", want, msg)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestImport_invalidResourceAddr(t *testing.T) {
|
|
|
|
defer testChdir(t, testFixturePath("import-missing-resource-config"))()
|
|
|
|
|
|
|
|
statePath := testTempFile(t)
|
|
|
|
|
|
|
|
p := testProvider()
|
|
|
|
ui := new(cli.MockUi)
|
|
|
|
c := &ImportCommand{
|
|
|
|
Meta: Meta{
|
|
|
|
testingOverrides: metaOverridesForProvider(p),
|
|
|
|
Ui: ui,
|
|
|
|
},
|
|
|
|
}
|
|
|
|
|
|
|
|
args := []string{
|
|
|
|
"-state", statePath,
|
|
|
|
"bananas",
|
|
|
|
"bar",
|
|
|
|
}
|
|
|
|
code := c.Run(args)
|
|
|
|
if code != 1 {
|
|
|
|
t.Fatalf("import succeeded; expected failure")
|
|
|
|
}
|
|
|
|
|
|
|
|
msg := ui.ErrorWriter.String()
|
2018-10-10 02:47:53 +02:00
|
|
|
if want := `Error: Invalid address`; !strings.Contains(msg, want) {
|
2017-05-17 03:20:08 +02:00
|
|
|
t.Errorf("incorrect message\nwant substring: %s\ngot:\n%s", want, msg)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestImport_targetIsModule(t *testing.T) {
|
|
|
|
defer testChdir(t, testFixturePath("import-missing-resource-config"))()
|
|
|
|
|
|
|
|
statePath := testTempFile(t)
|
|
|
|
|
|
|
|
p := testProvider()
|
|
|
|
ui := new(cli.MockUi)
|
|
|
|
c := &ImportCommand{
|
|
|
|
Meta: Meta{
|
|
|
|
testingOverrides: metaOverridesForProvider(p),
|
|
|
|
Ui: ui,
|
|
|
|
},
|
|
|
|
}
|
|
|
|
|
|
|
|
args := []string{
|
|
|
|
"-state", statePath,
|
|
|
|
"module.foo",
|
|
|
|
"bar",
|
|
|
|
}
|
|
|
|
code := c.Run(args)
|
|
|
|
if code != 1 {
|
|
|
|
t.Fatalf("import succeeded; expected failure")
|
|
|
|
}
|
|
|
|
|
|
|
|
msg := ui.ErrorWriter.String()
|
2018-10-10 02:47:53 +02:00
|
|
|
if want := `Error: Invalid address`; !strings.Contains(msg, want) {
|
2017-05-17 03:20:08 +02:00
|
|
|
t.Errorf("incorrect message\nwant substring: %s\ngot:\n%s", want, msg)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2017-06-27 17:07:45 +02:00
|
|
|
// make sure we search the full plugin path during import
|
|
|
|
func TestImport_pluginDir(t *testing.T) {
|
|
|
|
td := tempDir(t)
|
|
|
|
copy.CopyDir(testFixturePath("import-provider"), td)
|
|
|
|
defer os.RemoveAll(td)
|
|
|
|
defer testChdir(t, td)()
|
|
|
|
|
|
|
|
// make a fake provider in a custom plugin directory
|
|
|
|
if err := os.Mkdir("plugins", 0755); err != nil {
|
|
|
|
t.Fatal(err)
|
|
|
|
}
|
|
|
|
if err := ioutil.WriteFile("plugins/terraform-provider-test_v1.1.1_x4", []byte("invalid binary"), 0755); err != nil {
|
|
|
|
t.Fatal(err)
|
|
|
|
}
|
|
|
|
|
|
|
|
ui := new(cli.MockUi)
|
|
|
|
c := &ImportCommand{
|
|
|
|
Meta: Meta{
|
|
|
|
Ui: ui,
|
|
|
|
},
|
|
|
|
}
|
|
|
|
|
|
|
|
// store our custom plugin path, which would normally happen during init
|
|
|
|
if err := c.storePluginPath([]string{"./plugins"}); err != nil {
|
|
|
|
t.Fatal(err)
|
|
|
|
}
|
|
|
|
|
|
|
|
// Now we need to go through some plugin init.
|
|
|
|
// This discovers our fake plugin and writes the lock file.
|
|
|
|
initCmd := &InitCommand{
|
|
|
|
Meta: Meta{
|
|
|
|
pluginPath: []string{"./plugins"},
|
command: "terraform init" can partially initialize for 0.12upgrade
There are a few constructs from 0.11 and prior that cause 0.12 parsing to
fail altogether, which previously created a chicken/egg problem because
we need to install the providers in order to run "terraform 0.12upgrade"
and thus fix the problem.
This changes "terraform init" to use the new "early configuration" loader
for module and provider installation. This is built on the more permissive
parser in the terraform-config-inspect package, and so it allows us to
read out the top-level blocks from the configuration while accepting
legacy HCL syntax.
In the long run this will let us do version compatibility detection before
attempting a "real" config load, giving us better error messages for any
future syntax additions, but in the short term the key thing is that it
allows us to install the dependencies even if the configuration isn't
fully valid.
Because backend init still requires full configuration, this introduces a
new mode of terraform init where it detects heuristically if it seems like
we need to do a configuration upgrade and does a partial init if so,
before finally directing the user to run "terraform 0.12upgrade" before
running any other commands.
The heuristic here is based on two assumptions:
- If the "early" loader finds no errors but the normal loader does, the
configuration is likely to be valid for Terraform 0.11 but not 0.12.
- If there's already a version constraint in the configuration that
excludes Terraform versions prior to v0.12 then the configuration is
probably _already_ upgraded and so it's just a normal syntax error,
even if the early loader didn't detect it.
Once the upgrade process is removed in 0.13.0 (users will be required to
go stepwise 0.11 -> 0.12 -> 0.13 to upgrade after that), some of this can
be simplified to remove that special mode, but the idea of doing the
dependency version checks against the liberal parser will remain valuable
to increase our chances of reporting version-based incompatibilities
rather than syntax errors as we add new features in future.
2019-01-14 20:11:00 +01:00
|
|
|
Ui: cli.NewMockUi(),
|
2017-06-27 17:07:45 +02:00
|
|
|
},
|
|
|
|
providerInstaller: &discovery.ProviderInstaller{
|
2019-01-16 20:00:08 +01:00
|
|
|
PluginProtocolVersion: discovery.PluginInstallProtocolVersion,
|
2017-06-27 17:07:45 +02:00
|
|
|
},
|
|
|
|
}
|
command: "terraform init" can partially initialize for 0.12upgrade
There are a few constructs from 0.11 and prior that cause 0.12 parsing to
fail altogether, which previously created a chicken/egg problem because
we need to install the providers in order to run "terraform 0.12upgrade"
and thus fix the problem.
This changes "terraform init" to use the new "early configuration" loader
for module and provider installation. This is built on the more permissive
parser in the terraform-config-inspect package, and so it allows us to
read out the top-level blocks from the configuration while accepting
legacy HCL syntax.
In the long run this will let us do version compatibility detection before
attempting a "real" config load, giving us better error messages for any
future syntax additions, but in the short term the key thing is that it
allows us to install the dependencies even if the configuration isn't
fully valid.
Because backend init still requires full configuration, this introduces a
new mode of terraform init where it detects heuristically if it seems like
we need to do a configuration upgrade and does a partial init if so,
before finally directing the user to run "terraform 0.12upgrade" before
running any other commands.
The heuristic here is based on two assumptions:
- If the "early" loader finds no errors but the normal loader does, the
configuration is likely to be valid for Terraform 0.11 but not 0.12.
- If there's already a version constraint in the configuration that
excludes Terraform versions prior to v0.12 then the configuration is
probably _already_ upgraded and so it's just a normal syntax error,
even if the early loader didn't detect it.
Once the upgrade process is removed in 0.13.0 (users will be required to
go stepwise 0.11 -> 0.12 -> 0.13 to upgrade after that), some of this can
be simplified to remove that special mode, but the idea of doing the
dependency version checks against the liberal parser will remain valuable
to increase our chances of reporting version-based incompatibilities
rather than syntax errors as we add new features in future.
2019-01-14 20:11:00 +01:00
|
|
|
if code := initCmd.Run(nil); code != 0 {
|
|
|
|
t.Fatal(initCmd.Meta.Ui.(*cli.MockUi).ErrorWriter.String())
|
2017-06-27 17:07:45 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
args := []string{
|
|
|
|
"test_instance.foo",
|
|
|
|
"bar",
|
|
|
|
}
|
|
|
|
if code := c.Run(args); code == 0 {
|
|
|
|
t.Fatalf("expected error, got: %s", ui.OutputWriter)
|
|
|
|
}
|
|
|
|
|
|
|
|
outMsg := ui.OutputWriter.String()
|
|
|
|
// if we were missing a plugin, the output will have some explanation
|
|
|
|
// about requirements. If discovery starts verifying binary compatibility,
|
|
|
|
// we will need to write a dummy provider above.
|
|
|
|
if strings.Contains(outMsg, "requirements") {
|
|
|
|
t.Fatal("unexpected output:", outMsg)
|
|
|
|
}
|
|
|
|
|
|
|
|
// We wanted a plugin execution error, rather than a requirement error.
|
|
|
|
// Looking for "exec" in the error should suffice for now.
|
|
|
|
errMsg := ui.ErrorWriter.String()
|
|
|
|
if !strings.Contains(errMsg, "exec") {
|
|
|
|
t.Fatal("unexpected error:", errMsg)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-05-04 19:48:16 +02:00
|
|
|
const testImportStr = `
|
2016-05-04 19:32:08 +02:00
|
|
|
test_instance.foo:
|
2016-05-04 19:48:16 +02:00
|
|
|
ID = yay
|
2017-11-08 03:18:01 +01:00
|
|
|
provider = provider.test
|
2016-05-04 19:32:08 +02:00
|
|
|
`
|
2016-11-23 10:44:52 +01:00
|
|
|
|
|
|
|
const testImportCustomProviderStr = `
|
|
|
|
test_instance.foo:
|
|
|
|
ID = yay
|
2017-11-08 03:18:01 +01:00
|
|
|
provider = provider.test.alias
|
2016-11-23 10:44:52 +01:00
|
|
|
`
|
2019-09-20 16:02:42 +02:00
|
|
|
|
|
|
|
const testImportProviderMismatchStr = `
|
|
|
|
test_instance.foo:
|
|
|
|
ID = yay
|
|
|
|
provider = provider.test-beta
|
|
|
|
`
|