backend/local: Replace CLI with view instance
This commit extracts the remaining UI logic from the local backend,
and removes access to the direct CLI output. This is replaced with an
instance of a `views.Operation` interface, which codifies the current
requirements for the local backend to interact with the user.
The exception to this at present is interactivity: approving a plan
still depends on the `UIIn` field for the backend. This is out of scope
for this commit and can be revisited separately, at which time the
`UIOut` field can also be removed.
Changes in support of this:
- Some instances of direct error output have been replaced with
diagnostics, most notably in the emergency state backup handler. This
requires reformatting the error messages to allow the diagnostic
renderer to line-wrap them;
- The "in-automation" logic has moved out of the backend and into the
view implementation;
- The plan, apply, refresh, and import commands instantiate a view and
set it on the `backend.Operation` struct, as these are the only code
paths which call the `local.Operation()` method that requires it;
- The show command requires the plan rendering code which is now in the
views package, so there is a stub implementation of a `views.Show`
interface there.
Other refactoring work in support of migrating these commands to the
common views code structure will come in follow-up PRs, at which point
we will be able to remove the UI instances from the unit tests for those
commands.
2021-02-17 19:01:30 +01:00
|
|
|
package views
|
|
|
|
|
|
|
|
import (
|
|
|
|
"encoding/json"
|
|
|
|
"strings"
|
|
|
|
"testing"
|
|
|
|
|
|
|
|
"github.com/hashicorp/terraform/command/arguments"
|
|
|
|
"github.com/hashicorp/terraform/internal/terminal"
|
2021-04-06 01:28:59 +02:00
|
|
|
"github.com/hashicorp/terraform/plans"
|
backend/local: Replace CLI with view instance
This commit extracts the remaining UI logic from the local backend,
and removes access to the direct CLI output. This is replaced with an
instance of a `views.Operation` interface, which codifies the current
requirements for the local backend to interact with the user.
The exception to this at present is interactivity: approving a plan
still depends on the `UIIn` field for the backend. This is out of scope
for this commit and can be revisited separately, at which time the
`UIOut` field can also be removed.
Changes in support of this:
- Some instances of direct error output have been replaced with
diagnostics, most notably in the emergency state backup handler. This
requires reformatting the error messages to allow the diagnostic
renderer to line-wrap them;
- The "in-automation" logic has moved out of the backend and into the
view implementation;
- The plan, apply, refresh, and import commands instantiate a view and
set it on the `backend.Operation` struct, as these are the only code
paths which call the `local.Operation()` method that requires it;
- The show command requires the plan rendering code which is now in the
views package, so there is a stub implementation of a `views.Show`
interface there.
Other refactoring work in support of migrating these commands to the
common views code structure will come in follow-up PRs, at which point
we will be able to remove the UI instances from the unit tests for those
commands.
2021-02-17 19:01:30 +01:00
|
|
|
"github.com/hashicorp/terraform/states"
|
|
|
|
"github.com/hashicorp/terraform/states/statefile"
|
|
|
|
)
|
|
|
|
|
|
|
|
func TestOperation_stopping(t *testing.T) {
|
|
|
|
streams, done := terminal.StreamsForTesting(t)
|
|
|
|
v := NewOperation(arguments.ViewHuman, false, NewView(streams))
|
|
|
|
|
|
|
|
v.Stopping()
|
|
|
|
|
|
|
|
if got, want := done(t).Stdout(), "Stopping operation...\n"; got != want {
|
|
|
|
t.Errorf("wrong result\ngot: %q\nwant: %q", got, want)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestOperation_cancelled(t *testing.T) {
|
|
|
|
testCases := map[string]struct {
|
2021-04-06 01:28:59 +02:00
|
|
|
planMode plans.Mode
|
|
|
|
want string
|
backend/local: Replace CLI with view instance
This commit extracts the remaining UI logic from the local backend,
and removes access to the direct CLI output. This is replaced with an
instance of a `views.Operation` interface, which codifies the current
requirements for the local backend to interact with the user.
The exception to this at present is interactivity: approving a plan
still depends on the `UIIn` field for the backend. This is out of scope
for this commit and can be revisited separately, at which time the
`UIOut` field can also be removed.
Changes in support of this:
- Some instances of direct error output have been replaced with
diagnostics, most notably in the emergency state backup handler. This
requires reformatting the error messages to allow the diagnostic
renderer to line-wrap them;
- The "in-automation" logic has moved out of the backend and into the
view implementation;
- The plan, apply, refresh, and import commands instantiate a view and
set it on the `backend.Operation` struct, as these are the only code
paths which call the `local.Operation()` method that requires it;
- The show command requires the plan rendering code which is now in the
views package, so there is a stub implementation of a `views.Show`
interface there.
Other refactoring work in support of migrating these commands to the
common views code structure will come in follow-up PRs, at which point
we will be able to remove the UI instances from the unit tests for those
commands.
2021-02-17 19:01:30 +01:00
|
|
|
}{
|
|
|
|
"apply": {
|
2021-04-06 01:28:59 +02:00
|
|
|
planMode: plans.NormalMode,
|
|
|
|
want: "Apply cancelled.\n",
|
backend/local: Replace CLI with view instance
This commit extracts the remaining UI logic from the local backend,
and removes access to the direct CLI output. This is replaced with an
instance of a `views.Operation` interface, which codifies the current
requirements for the local backend to interact with the user.
The exception to this at present is interactivity: approving a plan
still depends on the `UIIn` field for the backend. This is out of scope
for this commit and can be revisited separately, at which time the
`UIOut` field can also be removed.
Changes in support of this:
- Some instances of direct error output have been replaced with
diagnostics, most notably in the emergency state backup handler. This
requires reformatting the error messages to allow the diagnostic
renderer to line-wrap them;
- The "in-automation" logic has moved out of the backend and into the
view implementation;
- The plan, apply, refresh, and import commands instantiate a view and
set it on the `backend.Operation` struct, as these are the only code
paths which call the `local.Operation()` method that requires it;
- The show command requires the plan rendering code which is now in the
views package, so there is a stub implementation of a `views.Show`
interface there.
Other refactoring work in support of migrating these commands to the
common views code structure will come in follow-up PRs, at which point
we will be able to remove the UI instances from the unit tests for those
commands.
2021-02-17 19:01:30 +01:00
|
|
|
},
|
|
|
|
"destroy": {
|
2021-04-06 01:28:59 +02:00
|
|
|
planMode: plans.DestroyMode,
|
|
|
|
want: "Destroy cancelled.\n",
|
backend/local: Replace CLI with view instance
This commit extracts the remaining UI logic from the local backend,
and removes access to the direct CLI output. This is replaced with an
instance of a `views.Operation` interface, which codifies the current
requirements for the local backend to interact with the user.
The exception to this at present is interactivity: approving a plan
still depends on the `UIIn` field for the backend. This is out of scope
for this commit and can be revisited separately, at which time the
`UIOut` field can also be removed.
Changes in support of this:
- Some instances of direct error output have been replaced with
diagnostics, most notably in the emergency state backup handler. This
requires reformatting the error messages to allow the diagnostic
renderer to line-wrap them;
- The "in-automation" logic has moved out of the backend and into the
view implementation;
- The plan, apply, refresh, and import commands instantiate a view and
set it on the `backend.Operation` struct, as these are the only code
paths which call the `local.Operation()` method that requires it;
- The show command requires the plan rendering code which is now in the
views package, so there is a stub implementation of a `views.Show`
interface there.
Other refactoring work in support of migrating these commands to the
common views code structure will come in follow-up PRs, at which point
we will be able to remove the UI instances from the unit tests for those
commands.
2021-02-17 19:01:30 +01:00
|
|
|
},
|
|
|
|
}
|
|
|
|
for name, tc := range testCases {
|
|
|
|
t.Run(name, func(t *testing.T) {
|
|
|
|
streams, done := terminal.StreamsForTesting(t)
|
|
|
|
v := NewOperation(arguments.ViewHuman, false, NewView(streams))
|
|
|
|
|
2021-04-06 01:28:59 +02:00
|
|
|
v.Cancelled(tc.planMode)
|
backend/local: Replace CLI with view instance
This commit extracts the remaining UI logic from the local backend,
and removes access to the direct CLI output. This is replaced with an
instance of a `views.Operation` interface, which codifies the current
requirements for the local backend to interact with the user.
The exception to this at present is interactivity: approving a plan
still depends on the `UIIn` field for the backend. This is out of scope
for this commit and can be revisited separately, at which time the
`UIOut` field can also be removed.
Changes in support of this:
- Some instances of direct error output have been replaced with
diagnostics, most notably in the emergency state backup handler. This
requires reformatting the error messages to allow the diagnostic
renderer to line-wrap them;
- The "in-automation" logic has moved out of the backend and into the
view implementation;
- The plan, apply, refresh, and import commands instantiate a view and
set it on the `backend.Operation` struct, as these are the only code
paths which call the `local.Operation()` method that requires it;
- The show command requires the plan rendering code which is now in the
views package, so there is a stub implementation of a `views.Show`
interface there.
Other refactoring work in support of migrating these commands to the
common views code structure will come in follow-up PRs, at which point
we will be able to remove the UI instances from the unit tests for those
commands.
2021-02-17 19:01:30 +01:00
|
|
|
|
|
|
|
if got, want := done(t).Stdout(), tc.want; got != want {
|
|
|
|
t.Errorf("wrong result\ngot: %q\nwant: %q", got, want)
|
|
|
|
}
|
|
|
|
})
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestOperation_emergencyDumpState(t *testing.T) {
|
|
|
|
streams, done := terminal.StreamsForTesting(t)
|
|
|
|
v := NewOperation(arguments.ViewHuman, false, NewView(streams))
|
|
|
|
|
|
|
|
stateFile := statefile.New(nil, "foo", 1)
|
|
|
|
|
|
|
|
err := v.EmergencyDumpState(stateFile)
|
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("unexpected error dumping state: %s", err)
|
|
|
|
}
|
|
|
|
|
|
|
|
// Check that the result (on stderr) looks like JSON state
|
|
|
|
raw := done(t).Stderr()
|
|
|
|
var state map[string]interface{}
|
|
|
|
if err := json.Unmarshal([]byte(raw), &state); err != nil {
|
|
|
|
t.Fatalf("unexpected error parsing dumped state: %s\nraw:\n%s", err, raw)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestOperation_planNoChanges(t *testing.T) {
|
|
|
|
streams, done := terminal.StreamsForTesting(t)
|
|
|
|
v := NewOperation(arguments.ViewHuman, false, NewView(streams))
|
|
|
|
|
|
|
|
v.PlanNoChanges()
|
|
|
|
|
|
|
|
if got, want := done(t).Stdout(), "No changes. Infrastructure is up-to-date."; !strings.Contains(got, want) {
|
|
|
|
t.Errorf("wrong result\ngot: %q\nwant: %q", got, want)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestOperation_plan(t *testing.T) {
|
|
|
|
streams, done := terminal.StreamsForTesting(t)
|
|
|
|
v := NewOperation(arguments.ViewHuman, true, NewView(streams))
|
|
|
|
|
|
|
|
plan := testPlan(t)
|
|
|
|
state := states.NewState()
|
|
|
|
schemas := testSchemas()
|
|
|
|
v.Plan(plan, state, schemas)
|
|
|
|
|
|
|
|
want := `
|
|
|
|
Terraform used the selected providers to generate the following execution
|
|
|
|
plan. Resource actions are indicated with the following symbols:
|
|
|
|
+ create
|
|
|
|
|
|
|
|
Terraform will perform the following actions:
|
|
|
|
|
|
|
|
# test_resource.foo will be created
|
|
|
|
+ resource "test_resource" "foo" {
|
|
|
|
+ foo = "bar"
|
|
|
|
+ id = (known after apply)
|
|
|
|
}
|
|
|
|
|
|
|
|
Plan: 1 to add, 0 to change, 0 to destroy.
|
|
|
|
`
|
|
|
|
|
|
|
|
if got := done(t).Stdout(); got != want {
|
|
|
|
t.Errorf("unexpected output\ngot:\n%s\nwant:\n%s", got, want)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestOperation_planNextStep(t *testing.T) {
|
|
|
|
testCases := map[string]struct {
|
|
|
|
path string
|
|
|
|
want string
|
|
|
|
}{
|
|
|
|
"no state path": {
|
|
|
|
path: "",
|
|
|
|
want: "You didn't use the -out option",
|
|
|
|
},
|
|
|
|
"state path": {
|
|
|
|
path: "good plan.tfplan",
|
|
|
|
want: `terraform apply "good plan.tfplan"`,
|
|
|
|
},
|
|
|
|
}
|
|
|
|
for name, tc := range testCases {
|
|
|
|
t.Run(name, func(t *testing.T) {
|
|
|
|
streams, done := terminal.StreamsForTesting(t)
|
|
|
|
v := NewOperation(arguments.ViewHuman, false, NewView(streams))
|
|
|
|
|
|
|
|
v.PlanNextStep(tc.path)
|
|
|
|
|
|
|
|
if got := done(t).Stdout(); !strings.Contains(got, tc.want) {
|
|
|
|
t.Errorf("wrong result\ngot: %q\nwant: %q", got, tc.want)
|
|
|
|
}
|
|
|
|
})
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// The in-automation state is on the view itself, so testing it separately is
|
|
|
|
// clearer.
|
|
|
|
func TestOperation_planNextStepInAutomation(t *testing.T) {
|
|
|
|
streams, done := terminal.StreamsForTesting(t)
|
|
|
|
v := NewOperation(arguments.ViewHuman, true, NewView(streams))
|
|
|
|
|
|
|
|
v.PlanNextStep("")
|
|
|
|
|
|
|
|
if got := done(t).Stdout(); got != "" {
|
|
|
|
t.Errorf("unexpected output\ngot: %q", got)
|
|
|
|
}
|
|
|
|
}
|