2018-06-09 01:18:30 +02:00
|
|
|
package statemgr
|
|
|
|
|
|
|
|
import (
|
|
|
|
"reflect"
|
|
|
|
"testing"
|
|
|
|
|
|
|
|
"github.com/davecgh/go-spew/spew"
|
|
|
|
"github.com/zclconf/go-cty/cty"
|
|
|
|
|
Initial steps towards AbsProviderConfig/LocalProviderConfig separation (#23978)
* Introduce "Local" terminology for non-absolute provider config addresses
In a future change AbsProviderConfig and LocalProviderConfig are going to
become two entirely distinct types, rather than Abs embedding Local as
written here. This naming change is in preparation for that subsequent
work, which will also include introducing a new "ProviderConfig" type
that is an interface that AbsProviderConfig and LocalProviderConfig both
implement.
This is intended to be largely just a naming change to get started, so
we can deal with all of the messy renaming. However, this did also require
a slight change in modeling where the Resource.DefaultProviderConfig
method has become Resource.DefaultProvider returning a Provider address
directly, because this method doesn't have enough information to construct
a true and accurate LocalProviderConfig -- it would need to refer to the
configuration to know what this module is calling the provider it has
selected.
In order to leave a trail to follow for subsequent work, all of the
changes here are intended to ensure that remaining work will become
obvious via compile-time errors when all of the following changes happen:
- The concept of "legacy" provider addresses is removed from the addrs
package, including removing addrs.NewLegacyProvider and
addrs.Provider.LegacyString.
- addrs.AbsProviderConfig stops having addrs.LocalProviderConfig embedded
in it and has an addrs.Provider and a string alias directly instead.
- The provider-schema-handling parts of Terraform core are updated to
work with addrs.Provider to identify providers, rather than legacy
strings.
In particular, there are still several codepaths here making legacy
provider address assumptions (in order to limit the scope of this change)
but I've made sure each one is doing something that relies on at least
one of the above changes not having been made yet.
* addrs: ProviderConfig interface
In a (very) few special situations in the main "terraform" package we need
to make runtime decisions about whether a provider config is absolute
or local.
We currently do that by exploiting the fact that AbsProviderConfig has
LocalProviderConfig nested inside of it and so in the local case we can
just ignore the wrapping AbsProviderConfig and use the embedded value.
In a future change we'll be moving away from that embedding and making
these two types distinct in order to represent that mapping between them
requires consulting a lookup table in the configuration, and so here we
introduce a new interface type ProviderConfig that can represent either
AbsProviderConfig or LocalProviderConfig decided dynamically at runtime.
This also includes the Config.ResolveAbsProviderAddr method that will
eventually be responsible for that local-to-absolute translation, so
that callers with access to the configuration can normalize to an
addrs.AbsProviderConfig given a non-nil addrs.ProviderConfig. That's
currently unused because existing callers are still relying on the
simplistic structural transform, but we'll switch them over in a later
commit.
* rename LocalType to LocalName
Co-authored-by: Kristin Laemmert <mildwonkey@users.noreply.github.com>
2020-01-31 14:23:07 +01:00
|
|
|
"github.com/hashicorp/terraform/addrs"
|
2018-06-09 01:18:30 +02:00
|
|
|
"github.com/hashicorp/terraform/states"
|
Initial steps towards AbsProviderConfig/LocalProviderConfig separation (#23978)
* Introduce "Local" terminology for non-absolute provider config addresses
In a future change AbsProviderConfig and LocalProviderConfig are going to
become two entirely distinct types, rather than Abs embedding Local as
written here. This naming change is in preparation for that subsequent
work, which will also include introducing a new "ProviderConfig" type
that is an interface that AbsProviderConfig and LocalProviderConfig both
implement.
This is intended to be largely just a naming change to get started, so
we can deal with all of the messy renaming. However, this did also require
a slight change in modeling where the Resource.DefaultProviderConfig
method has become Resource.DefaultProvider returning a Provider address
directly, because this method doesn't have enough information to construct
a true and accurate LocalProviderConfig -- it would need to refer to the
configuration to know what this module is calling the provider it has
selected.
In order to leave a trail to follow for subsequent work, all of the
changes here are intended to ensure that remaining work will become
obvious via compile-time errors when all of the following changes happen:
- The concept of "legacy" provider addresses is removed from the addrs
package, including removing addrs.NewLegacyProvider and
addrs.Provider.LegacyString.
- addrs.AbsProviderConfig stops having addrs.LocalProviderConfig embedded
in it and has an addrs.Provider and a string alias directly instead.
- The provider-schema-handling parts of Terraform core are updated to
work with addrs.Provider to identify providers, rather than legacy
strings.
In particular, there are still several codepaths here making legacy
provider address assumptions (in order to limit the scope of this change)
but I've made sure each one is doing something that relies on at least
one of the above changes not having been made yet.
* addrs: ProviderConfig interface
In a (very) few special situations in the main "terraform" package we need
to make runtime decisions about whether a provider config is absolute
or local.
We currently do that by exploiting the fact that AbsProviderConfig has
LocalProviderConfig nested inside of it and so in the local case we can
just ignore the wrapping AbsProviderConfig and use the embedded value.
In a future change we'll be moving away from that embedding and making
these two types distinct in order to represent that mapping between them
requires consulting a lookup table in the configuration, and so here we
introduce a new interface type ProviderConfig that can represent either
AbsProviderConfig or LocalProviderConfig decided dynamically at runtime.
This also includes the Config.ResolveAbsProviderAddr method that will
eventually be responsible for that local-to-absolute translation, so
that callers with access to the configuration can normalize to an
addrs.AbsProviderConfig given a non-nil addrs.ProviderConfig. That's
currently unused because existing callers are still relying on the
simplistic structural transform, but we'll switch them over in a later
commit.
* rename LocalType to LocalName
Co-authored-by: Kristin Laemmert <mildwonkey@users.noreply.github.com>
2020-01-31 14:23:07 +01:00
|
|
|
"github.com/hashicorp/terraform/states/statefile"
|
2018-06-09 01:18:30 +02:00
|
|
|
)
|
|
|
|
|
|
|
|
// TestFull is a helper for testing full state manager implementations. It
|
|
|
|
// expects that the given implementation is pre-loaded with a snapshot of the
|
|
|
|
// result from TestFullInitialState.
|
|
|
|
//
|
|
|
|
// If the given state manager also implements PersistentMeta, this function
|
|
|
|
// will test that the snapshot metadata changes as expected between calls
|
|
|
|
// to the methods of Persistent.
|
|
|
|
func TestFull(t *testing.T, s Full) {
|
|
|
|
t.Helper()
|
|
|
|
|
|
|
|
if err := s.RefreshState(); err != nil {
|
|
|
|
t.Fatalf("err: %s", err)
|
|
|
|
}
|
|
|
|
|
|
|
|
// Check that the initial state is correct.
|
|
|
|
// These do have different Lineages, but we will replace current below.
|
|
|
|
initial := TestFullInitialState()
|
|
|
|
if state := s.State(); !state.Equal(initial) {
|
|
|
|
t.Fatalf("state does not match expected initial state\n\ngot:\n%s\nwant:\n%s", spew.Sdump(state), spew.Sdump(initial))
|
|
|
|
}
|
|
|
|
|
|
|
|
var initialMeta SnapshotMeta
|
|
|
|
if sm, ok := s.(PersistentMeta); ok {
|
|
|
|
initialMeta = sm.StateSnapshotMeta()
|
|
|
|
}
|
|
|
|
|
|
|
|
// Now we've proven that the state we're starting with is an initial
|
|
|
|
// state, we'll complete our work here with that state, since otherwise
|
|
|
|
// further writes would violate the invariant that we only try to write
|
|
|
|
// states that share the same lineage as what was initially written.
|
|
|
|
current := s.State()
|
|
|
|
|
|
|
|
// Write a new state and verify that we have it
|
|
|
|
current.RootModule().SetOutputValue("bar", cty.StringVal("baz"), false)
|
|
|
|
|
|
|
|
if err := s.WriteState(current); err != nil {
|
|
|
|
t.Fatalf("err: %s", err)
|
|
|
|
}
|
|
|
|
|
|
|
|
if actual := s.State(); !actual.Equal(current) {
|
|
|
|
t.Fatalf("bad:\n%#v\n\n%#v", actual, current)
|
|
|
|
}
|
|
|
|
|
|
|
|
// Test persistence
|
|
|
|
if err := s.PersistState(); err != nil {
|
|
|
|
t.Fatalf("err: %s", err)
|
|
|
|
}
|
|
|
|
|
|
|
|
// Refresh if we got it
|
|
|
|
if err := s.RefreshState(); err != nil {
|
|
|
|
t.Fatalf("err: %s", err)
|
|
|
|
}
|
|
|
|
|
|
|
|
var newMeta SnapshotMeta
|
|
|
|
if sm, ok := s.(PersistentMeta); ok {
|
|
|
|
newMeta = sm.StateSnapshotMeta()
|
|
|
|
if got, want := newMeta.Lineage, initialMeta.Lineage; got != want {
|
|
|
|
t.Errorf("Lineage changed from %q to %q", want, got)
|
|
|
|
}
|
|
|
|
if after, before := newMeta.Serial, initialMeta.Serial; after == before {
|
|
|
|
t.Errorf("Serial didn't change from %d after new module added", before)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Same serial
|
|
|
|
serial := newMeta.Serial
|
|
|
|
if err := s.WriteState(current); err != nil {
|
|
|
|
t.Fatalf("err: %s", err)
|
|
|
|
}
|
|
|
|
if err := s.PersistState(); err != nil {
|
|
|
|
t.Fatalf("err: %s", err)
|
|
|
|
}
|
|
|
|
|
|
|
|
if sm, ok := s.(PersistentMeta); ok {
|
|
|
|
newMeta = sm.StateSnapshotMeta()
|
|
|
|
if newMeta.Serial != serial {
|
|
|
|
t.Fatalf("serial changed after persisting with no changes: got %d, want %d", newMeta.Serial, serial)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if sm, ok := s.(PersistentMeta); ok {
|
|
|
|
newMeta = sm.StateSnapshotMeta()
|
|
|
|
}
|
|
|
|
|
|
|
|
// Change the serial
|
|
|
|
current = current.DeepCopy()
|
|
|
|
current.EnsureModule(addrs.RootModuleInstance).SetOutputValue(
|
|
|
|
"serialCheck", cty.StringVal("true"), false,
|
|
|
|
)
|
|
|
|
if err := s.WriteState(current); err != nil {
|
|
|
|
t.Fatalf("err: %s", err)
|
|
|
|
}
|
|
|
|
if err := s.PersistState(); err != nil {
|
|
|
|
t.Fatalf("err: %s", err)
|
|
|
|
}
|
|
|
|
|
|
|
|
if sm, ok := s.(PersistentMeta); ok {
|
|
|
|
oldMeta := newMeta
|
|
|
|
newMeta = sm.StateSnapshotMeta()
|
|
|
|
|
|
|
|
if newMeta.Serial <= serial {
|
|
|
|
t.Fatalf("serial incorrect after persisting with changes: got %d, want > %d", newMeta.Serial, serial)
|
|
|
|
}
|
|
|
|
|
|
|
|
if newMeta.TerraformVersion != oldMeta.TerraformVersion {
|
|
|
|
t.Fatalf("TFVersion changed from %s to %s", oldMeta.TerraformVersion, newMeta.TerraformVersion)
|
|
|
|
}
|
|
|
|
|
|
|
|
// verify that Lineage doesn't change along with Serial, or during copying.
|
|
|
|
if newMeta.Lineage != oldMeta.Lineage {
|
|
|
|
t.Fatalf("Lineage changed from %q to %q", oldMeta.Lineage, newMeta.Lineage)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Check that State() returns a copy by modifying the copy and comparing
|
|
|
|
// to the current state.
|
|
|
|
stateCopy := s.State()
|
|
|
|
stateCopy.EnsureModule(addrs.RootModuleInstance.Child("another", addrs.NoKey))
|
|
|
|
if reflect.DeepEqual(stateCopy, s.State()) {
|
|
|
|
t.Fatal("State() should return a copy")
|
|
|
|
}
|
|
|
|
|
|
|
|
// our current expected state should also marshal identically to the persisted state
|
|
|
|
if !statefile.StatesMarshalEqual(current, s.State()) {
|
|
|
|
t.Fatalf("Persisted state altered unexpectedly.\n\ngot:\n%s\nwant:\n%s", spew.Sdump(s.State()), spew.Sdump(current))
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// TestFullInitialState is a state that should be snapshotted into a
|
|
|
|
// full state manager before passing it into TestFull.
|
|
|
|
func TestFullInitialState() *states.State {
|
|
|
|
state := states.NewState()
|
|
|
|
childMod := state.EnsureModule(addrs.RootModuleInstance.Child("child", addrs.NoKey))
|
|
|
|
rAddr := addrs.Resource{
|
|
|
|
Mode: addrs.ManagedResourceMode,
|
|
|
|
Type: "null_resource",
|
|
|
|
Name: "foo",
|
|
|
|
}
|
Initial steps towards AbsProviderConfig/LocalProviderConfig separation (#23978)
* Introduce "Local" terminology for non-absolute provider config addresses
In a future change AbsProviderConfig and LocalProviderConfig are going to
become two entirely distinct types, rather than Abs embedding Local as
written here. This naming change is in preparation for that subsequent
work, which will also include introducing a new "ProviderConfig" type
that is an interface that AbsProviderConfig and LocalProviderConfig both
implement.
This is intended to be largely just a naming change to get started, so
we can deal with all of the messy renaming. However, this did also require
a slight change in modeling where the Resource.DefaultProviderConfig
method has become Resource.DefaultProvider returning a Provider address
directly, because this method doesn't have enough information to construct
a true and accurate LocalProviderConfig -- it would need to refer to the
configuration to know what this module is calling the provider it has
selected.
In order to leave a trail to follow for subsequent work, all of the
changes here are intended to ensure that remaining work will become
obvious via compile-time errors when all of the following changes happen:
- The concept of "legacy" provider addresses is removed from the addrs
package, including removing addrs.NewLegacyProvider and
addrs.Provider.LegacyString.
- addrs.AbsProviderConfig stops having addrs.LocalProviderConfig embedded
in it and has an addrs.Provider and a string alias directly instead.
- The provider-schema-handling parts of Terraform core are updated to
work with addrs.Provider to identify providers, rather than legacy
strings.
In particular, there are still several codepaths here making legacy
provider address assumptions (in order to limit the scope of this change)
but I've made sure each one is doing something that relies on at least
one of the above changes not having been made yet.
* addrs: ProviderConfig interface
In a (very) few special situations in the main "terraform" package we need
to make runtime decisions about whether a provider config is absolute
or local.
We currently do that by exploiting the fact that AbsProviderConfig has
LocalProviderConfig nested inside of it and so in the local case we can
just ignore the wrapping AbsProviderConfig and use the embedded value.
In a future change we'll be moving away from that embedding and making
these two types distinct in order to represent that mapping between them
requires consulting a lookup table in the configuration, and so here we
introduce a new interface type ProviderConfig that can represent either
AbsProviderConfig or LocalProviderConfig decided dynamically at runtime.
This also includes the Config.ResolveAbsProviderAddr method that will
eventually be responsible for that local-to-absolute translation, so
that callers with access to the configuration can normalize to an
addrs.AbsProviderConfig given a non-nil addrs.ProviderConfig. That's
currently unused because existing callers are still relying on the
simplistic structural transform, but we'll switch them over in a later
commit.
* rename LocalType to LocalName
Co-authored-by: Kristin Laemmert <mildwonkey@users.noreply.github.com>
2020-01-31 14:23:07 +01:00
|
|
|
childMod.SetResourceMeta(rAddr, states.EachList, addrs.NewDefaultLocalProviderConfig(rAddr.DefaultProvider().LegacyString()).Absolute(addrs.RootModuleInstance))
|
2018-06-09 01:18:30 +02:00
|
|
|
return state
|
|
|
|
}
|