ResiLien
/
terraform
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
terraform/Makefile

64 lines
1.8 KiB
Makefile
Raw Normal View History

Initial work on config
2014-05-23 01:56:28 +02:00
TEST?=./...
Makefile: add vet target Add a vet target in order to catch suspicious constructs reported by go vet. Vet has successfully detected problems in the past, for example, see 482460c4c8a663ec2882bbddbb32da8e990de080 fc36b1cd9490233a3d220365fac3bc65679fe6de 68a41035a92606b6943c517fd874b54e8237485f 7b704fb77d6430cde07703f7cc8574484630d85c 4f3f85b1651d0c34c27c79cdbb772ecc07d6665a 95fa353ee928a42de1923d0f961e40d4ce201443 4bfe18b40d0749c073b3c4ba23f5c908436815d0 Some vet flags are noisy. In particular, the following flags reports a large amount of generally unharmful constructs: -assign: check for useless assignments -composites: check that composite literals used field-keyed elements -shadow: check for shadowed variables -shadowstrict: whether to be strict about shadowing -unreachable: check for unreachable code In order to skip running the flags mentioned above, vet is invoked on a directory basis with 'go tool vet .' since package- level type-checking with 'go vet' doesn't accept flags. Hence, each file is vetted in isolation, which is weaker than package-level type-checking. But nevertheless, it might catch suspicious constructs that pose a real problem. The vet target runs the following flags on the entire repo: -asmdecl: check assembly against Go declarations -atomic: check for common mistaken usages of the sync/atomic package -bool: check for mistakes involving boolean operators -buildtags: check that +build tags are valid -copylocks: check that locks are not passed by value -methods: check that canonically named methods are canonically defined -nilfunc: check for comparisons between functions and nil -printf: check printf-like invocations -rangeloops: check that range loop variables are used correctly -shift: check for useless shifts -structtags: check that struct field tags have canonical format and apply to exported fields as needed -unsafeptr: check for misuse of unsafe.Pointer Now and then, it might make sense to check the output of VETARGS=-unreachable make vet manually, just in case it detects several lines of dead code etc.
2015-01-16 22:20:32 +01:00
VETARGS?=-asmdecl -atomic -bool -buildtags -copylocks -methods -nilfunc -printf -rangeloops -shift -structtags -unsafeptr
Initial work on config
2014-05-23 01:56:28 +02:00
Default Makefile task should be to test
2014-05-24 02:00:51 +02:00
default: test
Comment Makefile
2015-01-27 03:19:22 +01:00
# bin generates the releaseable binaries for Terraform
config: remove unused files
2015-01-13 19:32:03 +01:00
bin: generate
quote $(CURDIR) to support $GOPATH with spaces
2014-11-26 00:29:15 +01:00
@sh -c "'$(CURDIR)/scripts/build.sh'"
Add `make dev` to make terraform dev bins
2014-06-07 05:25:17 +02:00
Comment Makefile
2015-01-27 03:19:22 +01:00
# dev creates binaries for testing Terraform locally. These are put
# into ./bin/ as well as $GOPATH/bin
config: remove unused files
2015-01-13 19:32:03 +01:00
dev: generate
quote $(CURDIR) to support $GOPATH with spaces
2014-11-26 00:29:15 +01:00
@TF_DEV=1 sh -c "'$(CURDIR)/scripts/build.sh'"
scripts: build script
2014-07-28 19:53:36 +02:00
Comment Makefile
2015-01-27 03:19:22 +01:00
# test runs the unit tests and vets the code
config: remove unused files
2015-01-13 19:32:03 +01:00
test: generate
Makefile: bump test timeout from 10s to 30s on a slow internet connection, the BitBucket tests were taking over 10s and panicing the test run
2015-01-24 16:57:15 +01:00
TF_ACC= go test $(TEST) $(TESTARGS) -timeout=30s -parallel=4
Makefile: add vet target Add a vet target in order to catch suspicious constructs reported by go vet. Vet has successfully detected problems in the past, for example, see 482460c4c8a663ec2882bbddbb32da8e990de080 fc36b1cd9490233a3d220365fac3bc65679fe6de 68a41035a92606b6943c517fd874b54e8237485f 7b704fb77d6430cde07703f7cc8574484630d85c 4f3f85b1651d0c34c27c79cdbb772ecc07d6665a 95fa353ee928a42de1923d0f961e40d4ce201443 4bfe18b40d0749c073b3c4ba23f5c908436815d0 Some vet flags are noisy. In particular, the following flags reports a large amount of generally unharmful constructs: -assign: check for useless assignments -composites: check that composite literals used field-keyed elements -shadow: check for shadowed variables -shadowstrict: whether to be strict about shadowing -unreachable: check for unreachable code In order to skip running the flags mentioned above, vet is invoked on a directory basis with 'go tool vet .' since package- level type-checking with 'go vet' doesn't accept flags. Hence, each file is vetted in isolation, which is weaker than package-level type-checking. But nevertheless, it might catch suspicious constructs that pose a real problem. The vet target runs the following flags on the entire repo: -asmdecl: check assembly against Go declarations -atomic: check for common mistaken usages of the sync/atomic package -bool: check for mistakes involving boolean operators -buildtags: check that +build tags are valid -copylocks: check that locks are not passed by value -methods: check that canonically named methods are canonically defined -nilfunc: check for comparisons between functions and nil -printf: check printf-like invocations -rangeloops: check that range loop variables are used correctly -shift: check for useless shifts -structtags: check that struct field tags have canonical format and apply to exported fields as needed -unsafeptr: check for misuse of unsafe.Pointer Now and then, it might make sense to check the output of VETARGS=-unreachable make vet manually, just in case it detects several lines of dead code etc.
2015-01-16 22:20:32 +01:00
@$(MAKE) vet
Initial work on config
2014-05-23 01:56:28 +02:00
Comment Makefile
2015-01-27 03:19:22 +01:00
# testacc runs acceptance tests
config: remove unused files
2015-01-13 19:32:03 +01:00
testacc: generate
Add "testacc" target for easy acceptance testing
2014-07-10 20:41:18 +02:00
@if [ "$(TEST)" = "./..." ]; then \
echo "ERROR: Set TEST to a specific package"; \
exit 1; \
fi
core: refactoring the way sets work internally v2 This is a refactored solution for PR #616. Functionally this is still the same change, but it’s implemented a lot cleaner with less code and less changes to existing parts of TF.
2014-12-12 23:21:20 +01:00
TF_ACC=1 go test $(TEST) -v $(TESTARGS) -timeout 45m
Add "testacc" target for easy acceptance testing
2014-07-10 20:41:18 +02:00
Comment Makefile
2015-01-27 03:19:22 +01:00
# testrace runs the race checker
config: remove unused files
2015-01-13 19:32:03 +01:00
testrace: generate
testrace won't run acceptance tests
2014-07-10 22:33:57 +02:00
TF_ACC= go test -race $(TEST) $(TESTARGS)
Add testrace
2014-07-01 19:04:23 +02:00
Comment Makefile
2015-01-27 03:19:22 +01:00
# updatedeps installs all the dependencies that Terraform needs to run
# and build.
config: remove unused files
2015-01-13 19:32:03 +01:00
updatedeps:
Makefile: new deps strategy fixes deps in branches Currently when running `make updatedeps` from a branch, the dependency list from master ends up getting used. We tried to work around this in 35490f7812395ff46fcba52989b3fbc3e44215c3, and got part way there, but here's what was happening: - record the current SHA - run `go get -f -u -v ./...` which ends up checking out master - master is checked out early in the `go get` process, which means all subsequent dependencies are resolved from master - re-checkout the recorded SHA - run tests This works in most cases, except when the branch being tested actually changes the list of dependencies in some way. Here we move away from letting `go get -v` walk through everything in `./...`, instead building our own list of dependencies with the help of `deplist`. We can then filter terraform packages out from the list, so they don't get touched, and safely update the rest. This should solve problems like those observed in #899 and #900. __Note__: had to add a feature to deplist to make this work properly; see https://github.com/phinze/deplist/commit/016ef97111533b1b8500b1d0db55133e7dba495a Working on getting it accepted upstream.
2015-01-30 22:43:47 +01:00
go get -u github.com/phinze/deplist
Makefile: roll gox into updatedeps No need to have an extra dev bootstrapping step when we can automate it!
2015-01-21 02:36:47 +01:00
go get -u github.com/mitchellh/gox
helper/schema: generate strings for ValueType
2015-01-11 00:51:53 +01:00
go get -u golang.org/x/tools/cmd/stringer
Makefile: add vet target Add a vet target in order to catch suspicious constructs reported by go vet. Vet has successfully detected problems in the past, for example, see 482460c4c8a663ec2882bbddbb32da8e990de080 fc36b1cd9490233a3d220365fac3bc65679fe6de 68a41035a92606b6943c517fd874b54e8237485f 7b704fb77d6430cde07703f7cc8574484630d85c 4f3f85b1651d0c34c27c79cdbb772ecc07d6665a 95fa353ee928a42de1923d0f961e40d4ce201443 4bfe18b40d0749c073b3c4ba23f5c908436815d0 Some vet flags are noisy. In particular, the following flags reports a large amount of generally unharmful constructs: -assign: check for useless assignments -composites: check that composite literals used field-keyed elements -shadow: check for shadowed variables -shadowstrict: whether to be strict about shadowing -unreachable: check for unreachable code In order to skip running the flags mentioned above, vet is invoked on a directory basis with 'go tool vet .' since package- level type-checking with 'go vet' doesn't accept flags. Hence, each file is vetted in isolation, which is weaker than package-level type-checking. But nevertheless, it might catch suspicious constructs that pose a real problem. The vet target runs the following flags on the entire repo: -asmdecl: check assembly against Go declarations -atomic: check for common mistaken usages of the sync/atomic package -bool: check for mistakes involving boolean operators -buildtags: check that +build tags are valid -copylocks: check that locks are not passed by value -methods: check that canonically named methods are canonically defined -nilfunc: check for comparisons between functions and nil -printf: check printf-like invocations -rangeloops: check that range loop variables are used correctly -shift: check for useless shifts -structtags: check that struct field tags have canonical format and apply to exported fields as needed -unsafeptr: check for misuse of unsafe.Pointer Now and then, it might make sense to check the output of VETARGS=-unreachable make vet manually, just in case it detects several lines of dead code etc.
2015-01-16 22:20:32 +01:00
go get -u golang.org/x/tools/cmd/vet
Makefile: new deps strategy fixes deps in branches Currently when running `make updatedeps` from a branch, the dependency list from master ends up getting used. We tried to work around this in 35490f7812395ff46fcba52989b3fbc3e44215c3, and got part way there, but here's what was happening: - record the current SHA - run `go get -f -u -v ./...` which ends up checking out master - master is checked out early in the `go get` process, which means all subsequent dependencies are resolved from master - re-checkout the recorded SHA - run tests This works in most cases, except when the branch being tested actually changes the list of dependencies in some way. Here we move away from letting `go get -v` walk through everything in `./...`, instead building our own list of dependencies with the help of `deplist`. We can then filter terraform packages out from the list, so they don't get touched, and safely update the rest. This should solve problems like those observed in #899 and #900. __Note__: had to add a feature to deplist to make this work properly; see https://github.com/phinze/deplist/commit/016ef97111533b1b8500b1d0db55133e7dba495a Working on getting it accepted upstream.
2015-01-30 22:43:47 +01:00
go list github.com/hashicorp/terraform/... \
| xargs -n 1 deplist -s \
| grep -v github.com/hashicorp/terraform \
| sort -u \
| xargs go get -f -u -v
update README
2014-06-26 19:33:39 +02:00
Comment Makefile
2015-01-27 03:19:22 +01:00
# vet runs the Go source code static analysis tool `vet` to find
# any common errors.
Makefile: add vet target Add a vet target in order to catch suspicious constructs reported by go vet. Vet has successfully detected problems in the past, for example, see 482460c4c8a663ec2882bbddbb32da8e990de080 fc36b1cd9490233a3d220365fac3bc65679fe6de 68a41035a92606b6943c517fd874b54e8237485f 7b704fb77d6430cde07703f7cc8574484630d85c 4f3f85b1651d0c34c27c79cdbb772ecc07d6665a 95fa353ee928a42de1923d0f961e40d4ce201443 4bfe18b40d0749c073b3c4ba23f5c908436815d0 Some vet flags are noisy. In particular, the following flags reports a large amount of generally unharmful constructs: -assign: check for useless assignments -composites: check that composite literals used field-keyed elements -shadow: check for shadowed variables -shadowstrict: whether to be strict about shadowing -unreachable: check for unreachable code In order to skip running the flags mentioned above, vet is invoked on a directory basis with 'go tool vet .' since package- level type-checking with 'go vet' doesn't accept flags. Hence, each file is vetted in isolation, which is weaker than package-level type-checking. But nevertheless, it might catch suspicious constructs that pose a real problem. The vet target runs the following flags on the entire repo: -asmdecl: check assembly against Go declarations -atomic: check for common mistaken usages of the sync/atomic package -bool: check for mistakes involving boolean operators -buildtags: check that +build tags are valid -copylocks: check that locks are not passed by value -methods: check that canonically named methods are canonically defined -nilfunc: check for comparisons between functions and nil -printf: check printf-like invocations -rangeloops: check that range loop variables are used correctly -shift: check for useless shifts -structtags: check that struct field tags have canonical format and apply to exported fields as needed -unsafeptr: check for misuse of unsafe.Pointer Now and then, it might make sense to check the output of VETARGS=-unreachable make vet manually, just in case it detects several lines of dead code etc.
2015-01-16 22:20:32 +01:00
vet:
@go tool vet 2>/dev/null ; if [ $$? -eq 3 ]; then \
go get golang.org/x/tools/cmd/vet; \
fi
@echo "go tool vet $(VETARGS) ."
@go tool vet $(VETARGS) . ; if [ $$? -eq 1 ]; then \
echo ""; \
echo "Vet found suspicious constructs. Please check the reported constructs"; \
echo "and fix them if necessary before submitting the code for reviewal."; \
fi
Comment Makefile
2015-01-27 03:19:22 +01:00
# generate runs `go generate` to build the dynamically generated
# source files.
helper/schema: generate strings for ValueType
2015-01-11 00:51:53 +01:00
generate:
go generate ./...
Makefile: add vet target Add a vet target in order to catch suspicious constructs reported by go vet. Vet has successfully detected problems in the past, for example, see 482460c4c8a663ec2882bbddbb32da8e990de080 fc36b1cd9490233a3d220365fac3bc65679fe6de 68a41035a92606b6943c517fd874b54e8237485f 7b704fb77d6430cde07703f7cc8574484630d85c 4f3f85b1651d0c34c27c79cdbb772ecc07d6665a 95fa353ee928a42de1923d0f961e40d4ce201443 4bfe18b40d0749c073b3c4ba23f5c908436815d0 Some vet flags are noisy. In particular, the following flags reports a large amount of generally unharmful constructs: -assign: check for useless assignments -composites: check that composite literals used field-keyed elements -shadow: check for shadowed variables -shadowstrict: whether to be strict about shadowing -unreachable: check for unreachable code In order to skip running the flags mentioned above, vet is invoked on a directory basis with 'go tool vet .' since package- level type-checking with 'go vet' doesn't accept flags. Hence, each file is vetted in isolation, which is weaker than package-level type-checking. But nevertheless, it might catch suspicious constructs that pose a real problem. The vet target runs the following flags on the entire repo: -asmdecl: check assembly against Go declarations -atomic: check for common mistaken usages of the sync/atomic package -bool: check for mistakes involving boolean operators -buildtags: check that +build tags are valid -copylocks: check that locks are not passed by value -methods: check that canonically named methods are canonically defined -nilfunc: check for comparisons between functions and nil -printf: check printf-like invocations -rangeloops: check that range loop variables are used correctly -shift: check for useless shifts -structtags: check that struct field tags have canonical format and apply to exported fields as needed -unsafeptr: check for misuse of unsafe.Pointer Now and then, it might make sense to check the output of VETARGS=-unreachable make vet manually, just in case it detects several lines of dead code etc.
2015-01-16 22:20:32 +01:00
.PHONY: bin default generate test updatedeps vet