2019-11-19 18:00:20 +01:00
|
|
|
package nebula
|
|
|
|
|
|
|
|
import (
|
2019-12-13 22:45:21 +01:00
|
|
|
"bytes"
|
2019-11-19 18:00:20 +01:00
|
|
|
"encoding/binary"
|
|
|
|
"errors"
|
|
|
|
"math"
|
|
|
|
"net"
|
|
|
|
"testing"
|
|
|
|
"time"
|
2019-12-12 17:34:17 +01:00
|
|
|
|
|
|
|
"github.com/rcrowley/go-metrics"
|
|
|
|
"github.com/slackhq/nebula/cert"
|
|
|
|
"github.com/stretchr/testify/assert"
|
2019-11-19 18:00:20 +01:00
|
|
|
)
|
|
|
|
|
|
|
|
func TestNewFirewall(t *testing.T) {
|
|
|
|
c := &cert.NebulaCertificate{}
|
|
|
|
fw := NewFirewall(time.Second, time.Minute, time.Hour, c)
|
2020-08-01 00:53:36 +02:00
|
|
|
conntrack := fw.Conntrack
|
|
|
|
assert.NotNil(t, conntrack)
|
|
|
|
assert.NotNil(t, conntrack.Conns)
|
|
|
|
assert.NotNil(t, conntrack.TimerWheel)
|
2019-11-19 18:00:20 +01:00
|
|
|
assert.NotNil(t, fw.InRules)
|
|
|
|
assert.NotNil(t, fw.OutRules)
|
|
|
|
assert.Equal(t, time.Second, fw.TCPTimeout)
|
|
|
|
assert.Equal(t, time.Minute, fw.UDPTimeout)
|
|
|
|
assert.Equal(t, time.Hour, fw.DefaultTimeout)
|
|
|
|
|
2020-08-01 00:53:36 +02:00
|
|
|
assert.Equal(t, time.Hour, conntrack.TimerWheel.wheelDuration)
|
|
|
|
assert.Equal(t, time.Hour, conntrack.TimerWheel.wheelDuration)
|
|
|
|
assert.Equal(t, 3601, conntrack.TimerWheel.wheelLen)
|
2019-11-19 18:00:20 +01:00
|
|
|
|
|
|
|
fw = NewFirewall(time.Second, time.Hour, time.Minute, c)
|
2020-08-01 00:53:36 +02:00
|
|
|
assert.Equal(t, time.Hour, conntrack.TimerWheel.wheelDuration)
|
|
|
|
assert.Equal(t, 3601, conntrack.TimerWheel.wheelLen)
|
2019-11-19 18:00:20 +01:00
|
|
|
|
|
|
|
fw = NewFirewall(time.Hour, time.Second, time.Minute, c)
|
2020-08-01 00:53:36 +02:00
|
|
|
assert.Equal(t, time.Hour, conntrack.TimerWheel.wheelDuration)
|
|
|
|
assert.Equal(t, 3601, conntrack.TimerWheel.wheelLen)
|
2019-11-19 18:00:20 +01:00
|
|
|
|
|
|
|
fw = NewFirewall(time.Hour, time.Minute, time.Second, c)
|
2020-08-01 00:53:36 +02:00
|
|
|
assert.Equal(t, time.Hour, conntrack.TimerWheel.wheelDuration)
|
|
|
|
assert.Equal(t, 3601, conntrack.TimerWheel.wheelLen)
|
2019-11-19 18:00:20 +01:00
|
|
|
|
|
|
|
fw = NewFirewall(time.Minute, time.Hour, time.Second, c)
|
2020-08-01 00:53:36 +02:00
|
|
|
assert.Equal(t, time.Hour, conntrack.TimerWheel.wheelDuration)
|
|
|
|
assert.Equal(t, 3601, conntrack.TimerWheel.wheelLen)
|
2019-11-19 18:00:20 +01:00
|
|
|
|
|
|
|
fw = NewFirewall(time.Minute, time.Second, time.Hour, c)
|
2020-08-01 00:53:36 +02:00
|
|
|
assert.Equal(t, time.Hour, conntrack.TimerWheel.wheelDuration)
|
|
|
|
assert.Equal(t, 3601, conntrack.TimerWheel.wheelLen)
|
2019-11-19 18:00:20 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
func TestFirewall_AddRule(t *testing.T) {
|
2019-12-18 20:06:51 +01:00
|
|
|
ob := &bytes.Buffer{}
|
|
|
|
out := l.Out
|
|
|
|
l.SetOutput(ob)
|
|
|
|
defer l.SetOutput(out)
|
|
|
|
|
2019-11-19 18:00:20 +01:00
|
|
|
c := &cert.NebulaCertificate{}
|
|
|
|
fw := NewFirewall(time.Second, time.Minute, time.Hour, c)
|
|
|
|
assert.NotNil(t, fw.InRules)
|
|
|
|
assert.NotNil(t, fw.OutRules)
|
|
|
|
|
|
|
|
_, ti, _ := net.ParseCIDR("1.2.3.4/32")
|
|
|
|
|
|
|
|
assert.Nil(t, fw.AddRule(true, fwProtoTCP, 1, 1, []string{}, "", nil, "", ""))
|
2019-12-19 06:23:34 +01:00
|
|
|
// An empty rule is any
|
|
|
|
assert.True(t, fw.InRules.TCP[1].Any.Any)
|
2019-12-18 08:36:12 +01:00
|
|
|
assert.Empty(t, fw.InRules.TCP[1].Any.Groups)
|
|
|
|
assert.Empty(t, fw.InRules.TCP[1].Any.Hosts)
|
|
|
|
assert.Nil(t, fw.InRules.TCP[1].Any.CIDR.root.left)
|
|
|
|
assert.Nil(t, fw.InRules.TCP[1].Any.CIDR.root.right)
|
|
|
|
assert.Nil(t, fw.InRules.TCP[1].Any.CIDR.root.value)
|
2019-11-19 18:00:20 +01:00
|
|
|
|
|
|
|
fw = NewFirewall(time.Second, time.Minute, time.Hour, c)
|
|
|
|
assert.Nil(t, fw.AddRule(true, fwProtoUDP, 1, 1, []string{"g1"}, "", nil, "", ""))
|
2019-12-18 08:36:12 +01:00
|
|
|
assert.False(t, fw.InRules.UDP[1].Any.Any)
|
|
|
|
assert.Contains(t, fw.InRules.UDP[1].Any.Groups[0], "g1")
|
|
|
|
assert.Empty(t, fw.InRules.UDP[1].Any.Hosts)
|
|
|
|
assert.Nil(t, fw.InRules.UDP[1].Any.CIDR.root.left)
|
|
|
|
assert.Nil(t, fw.InRules.UDP[1].Any.CIDR.root.right)
|
|
|
|
assert.Nil(t, fw.InRules.UDP[1].Any.CIDR.root.value)
|
2019-11-19 18:00:20 +01:00
|
|
|
|
|
|
|
fw = NewFirewall(time.Second, time.Minute, time.Hour, c)
|
|
|
|
assert.Nil(t, fw.AddRule(true, fwProtoICMP, 1, 1, []string{}, "h1", nil, "", ""))
|
2019-12-18 08:36:12 +01:00
|
|
|
assert.False(t, fw.InRules.ICMP[1].Any.Any)
|
|
|
|
assert.Empty(t, fw.InRules.ICMP[1].Any.Groups)
|
|
|
|
assert.Contains(t, fw.InRules.ICMP[1].Any.Hosts, "h1")
|
|
|
|
assert.Nil(t, fw.InRules.ICMP[1].Any.CIDR.root.left)
|
|
|
|
assert.Nil(t, fw.InRules.ICMP[1].Any.CIDR.root.right)
|
|
|
|
assert.Nil(t, fw.InRules.ICMP[1].Any.CIDR.root.value)
|
2019-11-19 18:00:20 +01:00
|
|
|
|
|
|
|
fw = NewFirewall(time.Second, time.Minute, time.Hour, c)
|
|
|
|
assert.Nil(t, fw.AddRule(false, fwProtoAny, 1, 1, []string{}, "", ti, "", ""))
|
2019-12-18 08:36:12 +01:00
|
|
|
assert.False(t, fw.OutRules.AnyProto[1].Any.Any)
|
|
|
|
assert.Empty(t, fw.OutRules.AnyProto[1].Any.Groups)
|
|
|
|
assert.Empty(t, fw.OutRules.AnyProto[1].Any.Hosts)
|
|
|
|
assert.NotNil(t, fw.OutRules.AnyProto[1].Any.CIDR.Match(ip2int(ti.IP)))
|
2019-11-19 18:00:20 +01:00
|
|
|
|
|
|
|
fw = NewFirewall(time.Second, time.Minute, time.Hour, c)
|
|
|
|
assert.Nil(t, fw.AddRule(true, fwProtoUDP, 1, 1, []string{"g1"}, "", nil, "ca-name", ""))
|
|
|
|
assert.Contains(t, fw.InRules.UDP[1].CANames, "ca-name")
|
|
|
|
|
|
|
|
fw = NewFirewall(time.Second, time.Minute, time.Hour, c)
|
|
|
|
assert.Nil(t, fw.AddRule(true, fwProtoUDP, 1, 1, []string{"g1"}, "", nil, "", "ca-sha"))
|
|
|
|
assert.Contains(t, fw.InRules.UDP[1].CAShas, "ca-sha")
|
|
|
|
|
|
|
|
// Set any and clear fields
|
|
|
|
fw = NewFirewall(time.Second, time.Minute, time.Hour, c)
|
|
|
|
assert.Nil(t, fw.AddRule(false, fwProtoAny, 0, 0, []string{"g1", "g2"}, "h1", ti, "", ""))
|
2019-12-18 08:36:12 +01:00
|
|
|
assert.Equal(t, []string{"g1", "g2"}, fw.OutRules.AnyProto[0].Any.Groups[0])
|
|
|
|
assert.Contains(t, fw.OutRules.AnyProto[0].Any.Hosts, "h1")
|
|
|
|
assert.NotNil(t, fw.OutRules.AnyProto[0].Any.CIDR.Match(ip2int(ti.IP)))
|
2019-11-19 18:00:20 +01:00
|
|
|
|
|
|
|
// run twice just to make sure
|
2019-12-18 08:36:12 +01:00
|
|
|
//TODO: these ANY rules should clear the CA firewall portion
|
2019-11-19 18:00:20 +01:00
|
|
|
assert.Nil(t, fw.AddRule(false, fwProtoAny, 0, 0, []string{"any"}, "", nil, "", ""))
|
|
|
|
assert.Nil(t, fw.AddRule(false, fwProtoAny, 0, 0, []string{}, "any", nil, "", ""))
|
2019-12-18 08:36:12 +01:00
|
|
|
assert.True(t, fw.OutRules.AnyProto[0].Any.Any)
|
|
|
|
assert.Empty(t, fw.OutRules.AnyProto[0].Any.Groups)
|
|
|
|
assert.Empty(t, fw.OutRules.AnyProto[0].Any.Hosts)
|
|
|
|
assert.Nil(t, fw.OutRules.AnyProto[0].Any.CIDR.root.left)
|
|
|
|
assert.Nil(t, fw.OutRules.AnyProto[0].Any.CIDR.root.right)
|
|
|
|
assert.Nil(t, fw.OutRules.AnyProto[0].Any.CIDR.root.value)
|
2019-11-19 18:00:20 +01:00
|
|
|
|
|
|
|
fw = NewFirewall(time.Second, time.Minute, time.Hour, c)
|
|
|
|
assert.Nil(t, fw.AddRule(false, fwProtoAny, 0, 0, []string{}, "any", nil, "", ""))
|
2019-12-18 08:36:12 +01:00
|
|
|
assert.True(t, fw.OutRules.AnyProto[0].Any.Any)
|
2019-11-19 18:00:20 +01:00
|
|
|
|
|
|
|
fw = NewFirewall(time.Second, time.Minute, time.Hour, c)
|
|
|
|
_, anyIp, _ := net.ParseCIDR("0.0.0.0/0")
|
|
|
|
assert.Nil(t, fw.AddRule(false, fwProtoAny, 0, 0, []string{}, "", anyIp, "", ""))
|
2019-12-18 08:36:12 +01:00
|
|
|
assert.True(t, fw.OutRules.AnyProto[0].Any.Any)
|
2019-11-19 18:00:20 +01:00
|
|
|
|
|
|
|
// Test error conditions
|
|
|
|
fw = NewFirewall(time.Second, time.Minute, time.Hour, c)
|
|
|
|
assert.Error(t, fw.AddRule(true, math.MaxUint8, 0, 0, []string{}, "", nil, "", ""))
|
|
|
|
assert.Error(t, fw.AddRule(true, fwProtoAny, 10, 0, []string{}, "", nil, "", ""))
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestFirewall_Drop(t *testing.T) {
|
2019-12-18 20:06:51 +01:00
|
|
|
ob := &bytes.Buffer{}
|
|
|
|
out := l.Out
|
|
|
|
l.SetOutput(ob)
|
|
|
|
defer l.SetOutput(out)
|
|
|
|
|
2019-11-19 18:00:20 +01:00
|
|
|
p := FirewallPacket{
|
|
|
|
ip2int(net.IPv4(1, 2, 3, 4)),
|
2019-12-12 17:34:17 +01:00
|
|
|
ip2int(net.IPv4(1, 2, 3, 4)),
|
2019-11-19 18:00:20 +01:00
|
|
|
10,
|
|
|
|
90,
|
|
|
|
fwProtoUDP,
|
|
|
|
false,
|
|
|
|
}
|
|
|
|
|
|
|
|
ipNet := net.IPNet{
|
|
|
|
IP: net.IPv4(1, 2, 3, 4),
|
|
|
|
Mask: net.IPMask{255, 255, 255, 0},
|
|
|
|
}
|
|
|
|
|
|
|
|
c := cert.NebulaCertificate{
|
|
|
|
Details: cert.NebulaCertificateDetails{
|
2019-12-18 20:06:51 +01:00
|
|
|
Name: "host1",
|
|
|
|
Ips: []*net.IPNet{&ipNet},
|
|
|
|
Groups: []string{"default-group"},
|
|
|
|
InvertedGroups: map[string]struct{}{"default-group": {}},
|
|
|
|
Issuer: "signer-shasum",
|
2019-11-19 18:00:20 +01:00
|
|
|
},
|
|
|
|
}
|
2019-12-12 17:34:17 +01:00
|
|
|
h := HostInfo{
|
|
|
|
ConnectionState: &ConnectionState{
|
|
|
|
peerCert: &c,
|
|
|
|
},
|
2020-03-02 22:21:33 +01:00
|
|
|
hostId: ip2int(ipNet.IP),
|
2019-12-12 17:34:17 +01:00
|
|
|
}
|
|
|
|
h.CreateRemoteCIDR(&c)
|
2019-11-19 18:00:20 +01:00
|
|
|
|
|
|
|
fw := NewFirewall(time.Second, time.Minute, time.Hour, &c)
|
|
|
|
assert.Nil(t, fw.AddRule(true, fwProtoAny, 0, 0, []string{"any"}, "", nil, "", ""))
|
|
|
|
cp := cert.NewCAPool()
|
|
|
|
|
|
|
|
// Drop outbound
|
2021-03-02 01:52:17 +01:00
|
|
|
assert.Equal(t, fw.Drop([]byte{}, p, false, &h, cp, nil), ErrNoMatchingRule)
|
2019-11-19 18:00:20 +01:00
|
|
|
// Allow inbound
|
2019-12-19 06:23:34 +01:00
|
|
|
resetConntrack(fw)
|
2021-03-02 01:52:17 +01:00
|
|
|
assert.NoError(t, fw.Drop([]byte{}, p, true, &h, cp, nil))
|
2019-11-19 18:00:20 +01:00
|
|
|
// Allow outbound because conntrack
|
2021-03-02 01:52:17 +01:00
|
|
|
assert.NoError(t, fw.Drop([]byte{}, p, false, &h, cp, nil))
|
2019-12-12 17:34:17 +01:00
|
|
|
|
|
|
|
// test remote mismatch
|
|
|
|
oldRemote := p.RemoteIP
|
|
|
|
p.RemoteIP = ip2int(net.IPv4(1, 2, 3, 10))
|
2021-03-02 01:52:17 +01:00
|
|
|
assert.Equal(t, fw.Drop([]byte{}, p, false, &h, cp, nil), ErrInvalidRemoteIP)
|
2019-12-12 17:34:17 +01:00
|
|
|
p.RemoteIP = oldRemote
|
2019-11-19 18:00:20 +01:00
|
|
|
|
2019-12-18 20:06:51 +01:00
|
|
|
// ensure signer doesn't get in the way of group checks
|
2019-11-19 18:00:20 +01:00
|
|
|
fw = NewFirewall(time.Second, time.Minute, time.Hour, &c)
|
2019-12-18 20:06:51 +01:00
|
|
|
assert.Nil(t, fw.AddRule(true, fwProtoAny, 0, 0, []string{"nope"}, "", nil, "", "signer-shasum"))
|
|
|
|
assert.Nil(t, fw.AddRule(true, fwProtoAny, 0, 0, []string{"default-group"}, "", nil, "", "signer-shasum-bad"))
|
2021-03-02 01:52:17 +01:00
|
|
|
assert.Equal(t, fw.Drop([]byte{}, p, true, &h, cp, nil), ErrNoMatchingRule)
|
2019-11-19 18:00:20 +01:00
|
|
|
|
2019-12-18 20:06:51 +01:00
|
|
|
// test caSha doesn't drop on match
|
2019-11-19 18:00:20 +01:00
|
|
|
fw = NewFirewall(time.Second, time.Minute, time.Hour, &c)
|
2019-12-18 20:06:51 +01:00
|
|
|
assert.Nil(t, fw.AddRule(true, fwProtoAny, 0, 0, []string{"nope"}, "", nil, "", "signer-shasum-bad"))
|
|
|
|
assert.Nil(t, fw.AddRule(true, fwProtoAny, 0, 0, []string{"default-group"}, "", nil, "", "signer-shasum"))
|
2021-03-02 01:52:17 +01:00
|
|
|
assert.NoError(t, fw.Drop([]byte{}, p, true, &h, cp, nil))
|
2019-11-19 18:00:20 +01:00
|
|
|
|
2019-12-18 20:06:51 +01:00
|
|
|
// ensure ca name doesn't get in the way of group checks
|
2019-11-19 18:00:20 +01:00
|
|
|
cp.CAs["signer-shasum"] = &cert.NebulaCertificate{Details: cert.NebulaCertificateDetails{Name: "ca-good"}}
|
|
|
|
fw = NewFirewall(time.Second, time.Minute, time.Hour, &c)
|
2019-12-18 20:06:51 +01:00
|
|
|
assert.Nil(t, fw.AddRule(true, fwProtoAny, 0, 0, []string{"nope"}, "", nil, "ca-good", ""))
|
|
|
|
assert.Nil(t, fw.AddRule(true, fwProtoAny, 0, 0, []string{"default-group"}, "", nil, "ca-good-bad", ""))
|
2021-03-02 01:52:17 +01:00
|
|
|
assert.Equal(t, fw.Drop([]byte{}, p, true, &h, cp, nil), ErrNoMatchingRule)
|
2019-12-18 20:06:51 +01:00
|
|
|
|
|
|
|
// test caName doesn't drop on match
|
|
|
|
cp.CAs["signer-shasum"] = &cert.NebulaCertificate{Details: cert.NebulaCertificateDetails{Name: "ca-good"}}
|
|
|
|
fw = NewFirewall(time.Second, time.Minute, time.Hour, &c)
|
|
|
|
assert.Nil(t, fw.AddRule(true, fwProtoAny, 0, 0, []string{"nope"}, "", nil, "ca-good-bad", ""))
|
|
|
|
assert.Nil(t, fw.AddRule(true, fwProtoAny, 0, 0, []string{"default-group"}, "", nil, "ca-good", ""))
|
2021-03-02 01:52:17 +01:00
|
|
|
assert.NoError(t, fw.Drop([]byte{}, p, true, &h, cp, nil))
|
2019-11-19 18:00:20 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
func BenchmarkFirewallTable_match(b *testing.B) {
|
|
|
|
ft := FirewallTable{
|
|
|
|
TCP: firewallPort{},
|
|
|
|
}
|
|
|
|
|
|
|
|
_, n, _ := net.ParseCIDR("172.1.1.1/32")
|
2019-12-18 08:36:12 +01:00
|
|
|
_ = ft.TCP.addRule(10, 10, []string{"good-group"}, "good-host", n, "", "")
|
|
|
|
_ = ft.TCP.addRule(10, 10, []string{"good-group2"}, "good-host", n, "", "")
|
|
|
|
_ = ft.TCP.addRule(10, 10, []string{"good-group3"}, "good-host", n, "", "")
|
|
|
|
_ = ft.TCP.addRule(10, 10, []string{"good-group4"}, "good-host", n, "", "")
|
|
|
|
_ = ft.TCP.addRule(10, 10, []string{"good-group, good-group1"}, "good-host", n, "", "")
|
2019-11-19 18:00:20 +01:00
|
|
|
cp := cert.NewCAPool()
|
|
|
|
|
|
|
|
b.Run("fail on proto", func(b *testing.B) {
|
|
|
|
c := &cert.NebulaCertificate{}
|
|
|
|
for n := 0; n < b.N; n++ {
|
|
|
|
ft.match(FirewallPacket{Protocol: fwProtoUDP}, true, c, cp)
|
|
|
|
}
|
|
|
|
})
|
|
|
|
|
|
|
|
b.Run("fail on port", func(b *testing.B) {
|
|
|
|
c := &cert.NebulaCertificate{}
|
|
|
|
for n := 0; n < b.N; n++ {
|
|
|
|
ft.match(FirewallPacket{Protocol: fwProtoTCP, LocalPort: 1}, true, c, cp)
|
|
|
|
}
|
|
|
|
})
|
|
|
|
|
|
|
|
b.Run("fail all group, name, and cidr", func(b *testing.B) {
|
|
|
|
_, ip, _ := net.ParseCIDR("9.254.254.254/32")
|
|
|
|
c := &cert.NebulaCertificate{
|
|
|
|
Details: cert.NebulaCertificateDetails{
|
|
|
|
InvertedGroups: map[string]struct{}{"nope": {}},
|
|
|
|
Name: "nope",
|
|
|
|
Ips: []*net.IPNet{ip},
|
|
|
|
},
|
|
|
|
}
|
|
|
|
for n := 0; n < b.N; n++ {
|
|
|
|
ft.match(FirewallPacket{Protocol: fwProtoTCP, LocalPort: 10}, true, c, cp)
|
|
|
|
}
|
|
|
|
})
|
|
|
|
|
|
|
|
b.Run("pass on group", func(b *testing.B) {
|
|
|
|
c := &cert.NebulaCertificate{
|
|
|
|
Details: cert.NebulaCertificateDetails{
|
|
|
|
InvertedGroups: map[string]struct{}{"good-group": {}},
|
|
|
|
Name: "nope",
|
|
|
|
},
|
|
|
|
}
|
|
|
|
for n := 0; n < b.N; n++ {
|
|
|
|
ft.match(FirewallPacket{Protocol: fwProtoTCP, LocalPort: 10}, true, c, cp)
|
|
|
|
}
|
|
|
|
})
|
|
|
|
|
|
|
|
b.Run("pass on name", func(b *testing.B) {
|
|
|
|
c := &cert.NebulaCertificate{
|
|
|
|
Details: cert.NebulaCertificateDetails{
|
|
|
|
InvertedGroups: map[string]struct{}{"nope": {}},
|
|
|
|
Name: "good-host",
|
|
|
|
},
|
|
|
|
}
|
|
|
|
for n := 0; n < b.N; n++ {
|
|
|
|
ft.match(FirewallPacket{Protocol: fwProtoTCP, LocalPort: 10}, true, c, cp)
|
|
|
|
}
|
|
|
|
})
|
|
|
|
|
|
|
|
b.Run("pass on ip", func(b *testing.B) {
|
|
|
|
ip := ip2int(net.IPv4(172, 1, 1, 1))
|
|
|
|
c := &cert.NebulaCertificate{
|
|
|
|
Details: cert.NebulaCertificateDetails{
|
|
|
|
InvertedGroups: map[string]struct{}{"nope": {}},
|
|
|
|
Name: "good-host",
|
|
|
|
},
|
|
|
|
}
|
|
|
|
for n := 0; n < b.N; n++ {
|
|
|
|
ft.match(FirewallPacket{Protocol: fwProtoTCP, LocalPort: 10, RemoteIP: ip}, true, c, cp)
|
|
|
|
}
|
|
|
|
})
|
|
|
|
|
2019-12-18 08:36:12 +01:00
|
|
|
_ = ft.TCP.addRule(0, 0, []string{"good-group"}, "good-host", n, "", "")
|
2019-11-19 18:00:20 +01:00
|
|
|
|
|
|
|
b.Run("pass on ip with any port", func(b *testing.B) {
|
|
|
|
ip := ip2int(net.IPv4(172, 1, 1, 1))
|
|
|
|
c := &cert.NebulaCertificate{
|
|
|
|
Details: cert.NebulaCertificateDetails{
|
|
|
|
InvertedGroups: map[string]struct{}{"nope": {}},
|
|
|
|
Name: "good-host",
|
|
|
|
},
|
|
|
|
}
|
|
|
|
for n := 0; n < b.N; n++ {
|
|
|
|
ft.match(FirewallPacket{Protocol: fwProtoTCP, LocalPort: 100, RemoteIP: ip}, true, c, cp)
|
|
|
|
}
|
|
|
|
})
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestFirewall_Drop2(t *testing.T) {
|
2019-12-18 20:06:51 +01:00
|
|
|
ob := &bytes.Buffer{}
|
|
|
|
out := l.Out
|
|
|
|
l.SetOutput(ob)
|
|
|
|
defer l.SetOutput(out)
|
|
|
|
|
2019-11-19 18:00:20 +01:00
|
|
|
p := FirewallPacket{
|
|
|
|
ip2int(net.IPv4(1, 2, 3, 4)),
|
2019-12-12 17:34:17 +01:00
|
|
|
ip2int(net.IPv4(1, 2, 3, 4)),
|
2019-11-19 18:00:20 +01:00
|
|
|
10,
|
|
|
|
90,
|
|
|
|
fwProtoUDP,
|
|
|
|
false,
|
|
|
|
}
|
|
|
|
|
|
|
|
ipNet := net.IPNet{
|
|
|
|
IP: net.IPv4(1, 2, 3, 4),
|
|
|
|
Mask: net.IPMask{255, 255, 255, 0},
|
|
|
|
}
|
|
|
|
|
|
|
|
c := cert.NebulaCertificate{
|
|
|
|
Details: cert.NebulaCertificateDetails{
|
|
|
|
Name: "host1",
|
|
|
|
Ips: []*net.IPNet{&ipNet},
|
|
|
|
InvertedGroups: map[string]struct{}{"default-group": {}, "test-group": {}},
|
|
|
|
},
|
|
|
|
}
|
2019-12-12 17:34:17 +01:00
|
|
|
h := HostInfo{
|
|
|
|
ConnectionState: &ConnectionState{
|
|
|
|
peerCert: &c,
|
|
|
|
},
|
2020-03-02 22:21:33 +01:00
|
|
|
hostId: ip2int(ipNet.IP),
|
2019-12-12 17:34:17 +01:00
|
|
|
}
|
|
|
|
h.CreateRemoteCIDR(&c)
|
2019-11-19 18:00:20 +01:00
|
|
|
|
|
|
|
c1 := cert.NebulaCertificate{
|
|
|
|
Details: cert.NebulaCertificateDetails{
|
|
|
|
Name: "host1",
|
|
|
|
Ips: []*net.IPNet{&ipNet},
|
|
|
|
InvertedGroups: map[string]struct{}{"default-group": {}, "test-group-not": {}},
|
|
|
|
},
|
|
|
|
}
|
2019-12-12 17:34:17 +01:00
|
|
|
h1 := HostInfo{
|
|
|
|
ConnectionState: &ConnectionState{
|
|
|
|
peerCert: &c1,
|
|
|
|
},
|
|
|
|
}
|
|
|
|
h1.CreateRemoteCIDR(&c1)
|
2019-11-19 18:00:20 +01:00
|
|
|
|
|
|
|
fw := NewFirewall(time.Second, time.Minute, time.Hour, &c)
|
|
|
|
assert.Nil(t, fw.AddRule(true, fwProtoAny, 0, 0, []string{"default-group", "test-group"}, "", nil, "", ""))
|
|
|
|
cp := cert.NewCAPool()
|
|
|
|
|
2019-12-12 17:34:17 +01:00
|
|
|
// h1/c1 lacks the proper groups
|
2021-03-02 01:52:17 +01:00
|
|
|
assert.Error(t, fw.Drop([]byte{}, p, true, &h1, cp, nil), ErrNoMatchingRule)
|
2019-11-19 18:00:20 +01:00
|
|
|
// c has the proper groups
|
2019-12-19 06:23:34 +01:00
|
|
|
resetConntrack(fw)
|
2021-03-02 01:52:17 +01:00
|
|
|
assert.NoError(t, fw.Drop([]byte{}, p, true, &h, cp, nil))
|
2019-11-19 18:00:20 +01:00
|
|
|
}
|
|
|
|
|
2019-12-19 06:23:34 +01:00
|
|
|
func TestFirewall_Drop3(t *testing.T) {
|
|
|
|
ob := &bytes.Buffer{}
|
|
|
|
out := l.Out
|
|
|
|
l.SetOutput(ob)
|
|
|
|
defer l.SetOutput(out)
|
|
|
|
|
|
|
|
p := FirewallPacket{
|
|
|
|
ip2int(net.IPv4(1, 2, 3, 4)),
|
|
|
|
ip2int(net.IPv4(1, 2, 3, 4)),
|
|
|
|
1,
|
|
|
|
1,
|
|
|
|
fwProtoUDP,
|
|
|
|
false,
|
|
|
|
}
|
|
|
|
|
|
|
|
ipNet := net.IPNet{
|
|
|
|
IP: net.IPv4(1, 2, 3, 4),
|
|
|
|
Mask: net.IPMask{255, 255, 255, 0},
|
|
|
|
}
|
|
|
|
|
|
|
|
c := cert.NebulaCertificate{
|
|
|
|
Details: cert.NebulaCertificateDetails{
|
|
|
|
Name: "host-owner",
|
|
|
|
Ips: []*net.IPNet{&ipNet},
|
|
|
|
},
|
|
|
|
}
|
|
|
|
|
|
|
|
c1 := cert.NebulaCertificate{
|
|
|
|
Details: cert.NebulaCertificateDetails{
|
|
|
|
Name: "host1",
|
|
|
|
Ips: []*net.IPNet{&ipNet},
|
|
|
|
Issuer: "signer-sha-bad",
|
|
|
|
},
|
|
|
|
}
|
|
|
|
h1 := HostInfo{
|
|
|
|
ConnectionState: &ConnectionState{
|
|
|
|
peerCert: &c1,
|
|
|
|
},
|
2020-03-02 22:21:33 +01:00
|
|
|
hostId: ip2int(ipNet.IP),
|
2019-12-19 06:23:34 +01:00
|
|
|
}
|
|
|
|
h1.CreateRemoteCIDR(&c1)
|
|
|
|
|
|
|
|
c2 := cert.NebulaCertificate{
|
|
|
|
Details: cert.NebulaCertificateDetails{
|
|
|
|
Name: "host2",
|
|
|
|
Ips: []*net.IPNet{&ipNet},
|
|
|
|
Issuer: "signer-sha",
|
|
|
|
},
|
|
|
|
}
|
|
|
|
h2 := HostInfo{
|
|
|
|
ConnectionState: &ConnectionState{
|
|
|
|
peerCert: &c2,
|
|
|
|
},
|
2020-03-02 22:21:33 +01:00
|
|
|
hostId: ip2int(ipNet.IP),
|
2019-12-19 06:23:34 +01:00
|
|
|
}
|
|
|
|
h2.CreateRemoteCIDR(&c2)
|
|
|
|
|
|
|
|
c3 := cert.NebulaCertificate{
|
|
|
|
Details: cert.NebulaCertificateDetails{
|
|
|
|
Name: "host3",
|
|
|
|
Ips: []*net.IPNet{&ipNet},
|
|
|
|
Issuer: "signer-sha-bad",
|
|
|
|
},
|
|
|
|
}
|
|
|
|
h3 := HostInfo{
|
|
|
|
ConnectionState: &ConnectionState{
|
|
|
|
peerCert: &c3,
|
|
|
|
},
|
2020-03-02 22:21:33 +01:00
|
|
|
hostId: ip2int(ipNet.IP),
|
2019-12-19 06:23:34 +01:00
|
|
|
}
|
|
|
|
h3.CreateRemoteCIDR(&c3)
|
|
|
|
|
|
|
|
fw := NewFirewall(time.Second, time.Minute, time.Hour, &c)
|
|
|
|
assert.Nil(t, fw.AddRule(true, fwProtoAny, 1, 1, []string{}, "host1", nil, "", ""))
|
|
|
|
assert.Nil(t, fw.AddRule(true, fwProtoAny, 1, 1, []string{}, "", nil, "", "signer-sha"))
|
|
|
|
cp := cert.NewCAPool()
|
|
|
|
|
|
|
|
// c1 should pass because host match
|
2021-03-02 01:52:17 +01:00
|
|
|
assert.NoError(t, fw.Drop([]byte{}, p, true, &h1, cp, nil))
|
2019-12-19 06:23:34 +01:00
|
|
|
// c2 should pass because ca sha match
|
|
|
|
resetConntrack(fw)
|
2021-03-02 01:52:17 +01:00
|
|
|
assert.NoError(t, fw.Drop([]byte{}, p, true, &h2, cp, nil))
|
2019-12-19 06:23:34 +01:00
|
|
|
// c3 should fail because no match
|
|
|
|
resetConntrack(fw)
|
2021-03-02 01:52:17 +01:00
|
|
|
assert.Equal(t, fw.Drop([]byte{}, p, true, &h3, cp, nil), ErrNoMatchingRule)
|
2019-12-19 06:23:34 +01:00
|
|
|
}
|
|
|
|
|
2020-08-01 00:53:36 +02:00
|
|
|
func TestFirewall_DropConntrackReload(t *testing.T) {
|
|
|
|
ob := &bytes.Buffer{}
|
|
|
|
out := l.Out
|
|
|
|
l.SetOutput(ob)
|
|
|
|
defer l.SetOutput(out)
|
|
|
|
|
|
|
|
p := FirewallPacket{
|
|
|
|
ip2int(net.IPv4(1, 2, 3, 4)),
|
|
|
|
ip2int(net.IPv4(1, 2, 3, 4)),
|
|
|
|
10,
|
|
|
|
90,
|
|
|
|
fwProtoUDP,
|
|
|
|
false,
|
|
|
|
}
|
|
|
|
|
|
|
|
ipNet := net.IPNet{
|
|
|
|
IP: net.IPv4(1, 2, 3, 4),
|
|
|
|
Mask: net.IPMask{255, 255, 255, 0},
|
|
|
|
}
|
|
|
|
|
|
|
|
c := cert.NebulaCertificate{
|
|
|
|
Details: cert.NebulaCertificateDetails{
|
|
|
|
Name: "host1",
|
|
|
|
Ips: []*net.IPNet{&ipNet},
|
|
|
|
Groups: []string{"default-group"},
|
|
|
|
InvertedGroups: map[string]struct{}{"default-group": {}},
|
|
|
|
Issuer: "signer-shasum",
|
|
|
|
},
|
|
|
|
}
|
|
|
|
h := HostInfo{
|
|
|
|
ConnectionState: &ConnectionState{
|
|
|
|
peerCert: &c,
|
|
|
|
},
|
|
|
|
hostId: ip2int(ipNet.IP),
|
|
|
|
}
|
|
|
|
h.CreateRemoteCIDR(&c)
|
|
|
|
|
|
|
|
fw := NewFirewall(time.Second, time.Minute, time.Hour, &c)
|
|
|
|
assert.Nil(t, fw.AddRule(true, fwProtoAny, 0, 0, []string{"any"}, "", nil, "", ""))
|
|
|
|
cp := cert.NewCAPool()
|
|
|
|
|
|
|
|
// Drop outbound
|
2021-03-02 01:52:17 +01:00
|
|
|
assert.Equal(t, fw.Drop([]byte{}, p, false, &h, cp, nil), ErrNoMatchingRule)
|
2020-08-01 00:53:36 +02:00
|
|
|
// Allow inbound
|
|
|
|
resetConntrack(fw)
|
2021-03-02 01:52:17 +01:00
|
|
|
assert.NoError(t, fw.Drop([]byte{}, p, true, &h, cp, nil))
|
2020-08-01 00:53:36 +02:00
|
|
|
// Allow outbound because conntrack
|
2021-03-02 01:52:17 +01:00
|
|
|
assert.NoError(t, fw.Drop([]byte{}, p, false, &h, cp, nil))
|
2020-08-01 00:53:36 +02:00
|
|
|
|
|
|
|
oldFw := fw
|
|
|
|
fw = NewFirewall(time.Second, time.Minute, time.Hour, &c)
|
|
|
|
assert.Nil(t, fw.AddRule(true, fwProtoAny, 10, 10, []string{"any"}, "", nil, "", ""))
|
|
|
|
fw.Conntrack = oldFw.Conntrack
|
|
|
|
fw.rulesVersion = oldFw.rulesVersion + 1
|
|
|
|
|
|
|
|
// Allow outbound because conntrack and new rules allow port 10
|
2021-03-02 01:52:17 +01:00
|
|
|
assert.NoError(t, fw.Drop([]byte{}, p, false, &h, cp, nil))
|
2020-08-01 00:53:36 +02:00
|
|
|
|
|
|
|
oldFw = fw
|
|
|
|
fw = NewFirewall(time.Second, time.Minute, time.Hour, &c)
|
|
|
|
assert.Nil(t, fw.AddRule(true, fwProtoAny, 11, 11, []string{"any"}, "", nil, "", ""))
|
|
|
|
fw.Conntrack = oldFw.Conntrack
|
|
|
|
fw.rulesVersion = oldFw.rulesVersion + 1
|
|
|
|
|
|
|
|
// Drop outbound because conntrack doesn't match new ruleset
|
2021-03-02 01:52:17 +01:00
|
|
|
assert.Equal(t, fw.Drop([]byte{}, p, false, &h, cp, nil), ErrNoMatchingRule)
|
2020-08-01 00:53:36 +02:00
|
|
|
}
|
|
|
|
|
2019-11-19 18:00:20 +01:00
|
|
|
func BenchmarkLookup(b *testing.B) {
|
|
|
|
ml := func(m map[string]struct{}, a [][]string) {
|
|
|
|
for n := 0; n < b.N; n++ {
|
|
|
|
for _, sg := range a {
|
|
|
|
found := false
|
|
|
|
|
|
|
|
for _, g := range sg {
|
|
|
|
if _, ok := m[g]; !ok {
|
|
|
|
found = false
|
|
|
|
break
|
|
|
|
}
|
|
|
|
|
|
|
|
found = true
|
|
|
|
}
|
|
|
|
|
|
|
|
if found {
|
|
|
|
return
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
b.Run("array to map best", func(b *testing.B) {
|
|
|
|
m := map[string]struct{}{
|
|
|
|
"1ne": {},
|
|
|
|
"2wo": {},
|
|
|
|
"3hr": {},
|
|
|
|
"4ou": {},
|
|
|
|
"5iv": {},
|
|
|
|
"6ix": {},
|
|
|
|
}
|
|
|
|
|
|
|
|
a := [][]string{
|
|
|
|
{"1ne", "2wo", "3hr", "4ou", "5iv", "6ix"},
|
|
|
|
{"one", "2wo", "3hr", "4ou", "5iv", "6ix"},
|
|
|
|
{"one", "two", "3hr", "4ou", "5iv", "6ix"},
|
|
|
|
{"one", "two", "thr", "4ou", "5iv", "6ix"},
|
|
|
|
{"one", "two", "thr", "fou", "5iv", "6ix"},
|
|
|
|
{"one", "two", "thr", "fou", "fiv", "6ix"},
|
|
|
|
{"one", "two", "thr", "fou", "fiv", "six"},
|
|
|
|
}
|
|
|
|
|
|
|
|
for n := 0; n < b.N; n++ {
|
|
|
|
ml(m, a)
|
|
|
|
}
|
|
|
|
})
|
|
|
|
|
|
|
|
b.Run("array to map worst", func(b *testing.B) {
|
|
|
|
m := map[string]struct{}{
|
|
|
|
"one": {},
|
|
|
|
"two": {},
|
|
|
|
"thr": {},
|
|
|
|
"fou": {},
|
|
|
|
"fiv": {},
|
|
|
|
"six": {},
|
|
|
|
}
|
|
|
|
|
|
|
|
a := [][]string{
|
|
|
|
{"1ne", "2wo", "3hr", "4ou", "5iv", "6ix"},
|
|
|
|
{"one", "2wo", "3hr", "4ou", "5iv", "6ix"},
|
|
|
|
{"one", "two", "3hr", "4ou", "5iv", "6ix"},
|
|
|
|
{"one", "two", "thr", "4ou", "5iv", "6ix"},
|
|
|
|
{"one", "two", "thr", "fou", "5iv", "6ix"},
|
|
|
|
{"one", "two", "thr", "fou", "fiv", "6ix"},
|
|
|
|
{"one", "two", "thr", "fou", "fiv", "six"},
|
|
|
|
}
|
|
|
|
|
|
|
|
for n := 0; n < b.N; n++ {
|
|
|
|
ml(m, a)
|
|
|
|
}
|
|
|
|
})
|
|
|
|
|
|
|
|
//TODO: only way array lookup in array will help is if both are sorted, then maybe it's faster
|
|
|
|
}
|
|
|
|
|
|
|
|
func Test_parsePort(t *testing.T) {
|
|
|
|
_, _, err := parsePort("")
|
|
|
|
assert.EqualError(t, err, "was not a number; ``")
|
|
|
|
|
|
|
|
_, _, err = parsePort(" ")
|
|
|
|
assert.EqualError(t, err, "was not a number; ` `")
|
|
|
|
|
|
|
|
_, _, err = parsePort("-")
|
|
|
|
assert.EqualError(t, err, "appears to be a range but could not be parsed; `-`")
|
|
|
|
|
|
|
|
_, _, err = parsePort(" - ")
|
|
|
|
assert.EqualError(t, err, "appears to be a range but could not be parsed; ` - `")
|
|
|
|
|
|
|
|
_, _, err = parsePort("a-b")
|
|
|
|
assert.EqualError(t, err, "beginning range was not a number; `a`")
|
|
|
|
|
|
|
|
_, _, err = parsePort("1-b")
|
|
|
|
assert.EqualError(t, err, "ending range was not a number; `b`")
|
|
|
|
|
|
|
|
s, e, err := parsePort(" 1 - 2 ")
|
|
|
|
assert.Equal(t, int32(1), s)
|
|
|
|
assert.Equal(t, int32(2), e)
|
|
|
|
assert.Nil(t, err)
|
|
|
|
|
|
|
|
s, e, err = parsePort("0-1")
|
|
|
|
assert.Equal(t, int32(0), s)
|
|
|
|
assert.Equal(t, int32(0), e)
|
|
|
|
assert.Nil(t, err)
|
|
|
|
|
|
|
|
s, e, err = parsePort("9919")
|
|
|
|
assert.Equal(t, int32(9919), s)
|
|
|
|
assert.Equal(t, int32(9919), e)
|
|
|
|
assert.Nil(t, err)
|
|
|
|
|
|
|
|
s, e, err = parsePort("any")
|
|
|
|
assert.Equal(t, int32(0), s)
|
|
|
|
assert.Equal(t, int32(0), e)
|
|
|
|
assert.Nil(t, err)
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestNewFirewallFromConfig(t *testing.T) {
|
|
|
|
// Test a bad rule definition
|
|
|
|
c := &cert.NebulaCertificate{}
|
|
|
|
conf := NewConfig()
|
|
|
|
conf.Settings["firewall"] = map[interface{}]interface{}{"outbound": "asdf"}
|
|
|
|
_, err := NewFirewallFromConfig(c, conf)
|
|
|
|
assert.EqualError(t, err, "firewall.outbound failed to parse, should be an array of rules")
|
|
|
|
|
|
|
|
// Test both port and code
|
|
|
|
conf = NewConfig()
|
|
|
|
conf.Settings["firewall"] = map[interface{}]interface{}{"outbound": []interface{}{map[interface{}]interface{}{"port": "1", "code": "2"}}}
|
|
|
|
_, err = NewFirewallFromConfig(c, conf)
|
|
|
|
assert.EqualError(t, err, "firewall.outbound rule #0; only one of port or code should be provided")
|
|
|
|
|
|
|
|
// Test missing host, group, cidr, ca_name and ca_sha
|
|
|
|
conf = NewConfig()
|
|
|
|
conf.Settings["firewall"] = map[interface{}]interface{}{"outbound": []interface{}{map[interface{}]interface{}{}}}
|
|
|
|
_, err = NewFirewallFromConfig(c, conf)
|
|
|
|
assert.EqualError(t, err, "firewall.outbound rule #0; at least one of host, group, cidr, ca_name, or ca_sha must be provided")
|
|
|
|
|
|
|
|
// Test code/port error
|
|
|
|
conf = NewConfig()
|
|
|
|
conf.Settings["firewall"] = map[interface{}]interface{}{"outbound": []interface{}{map[interface{}]interface{}{"code": "a", "host": "testh"}}}
|
|
|
|
_, err = NewFirewallFromConfig(c, conf)
|
|
|
|
assert.EqualError(t, err, "firewall.outbound rule #0; code was not a number; `a`")
|
|
|
|
|
|
|
|
conf.Settings["firewall"] = map[interface{}]interface{}{"outbound": []interface{}{map[interface{}]interface{}{"port": "a", "host": "testh"}}}
|
|
|
|
_, err = NewFirewallFromConfig(c, conf)
|
|
|
|
assert.EqualError(t, err, "firewall.outbound rule #0; port was not a number; `a`")
|
|
|
|
|
|
|
|
// Test proto error
|
|
|
|
conf = NewConfig()
|
|
|
|
conf.Settings["firewall"] = map[interface{}]interface{}{"outbound": []interface{}{map[interface{}]interface{}{"code": "1", "host": "testh"}}}
|
|
|
|
_, err = NewFirewallFromConfig(c, conf)
|
|
|
|
assert.EqualError(t, err, "firewall.outbound rule #0; proto was not understood; ``")
|
|
|
|
|
|
|
|
// Test cidr parse error
|
|
|
|
conf = NewConfig()
|
|
|
|
conf.Settings["firewall"] = map[interface{}]interface{}{"outbound": []interface{}{map[interface{}]interface{}{"code": "1", "cidr": "testh", "proto": "any"}}}
|
|
|
|
_, err = NewFirewallFromConfig(c, conf)
|
|
|
|
assert.EqualError(t, err, "firewall.outbound rule #0; cidr did not parse; invalid CIDR address: testh")
|
|
|
|
|
|
|
|
// Test both group and groups
|
|
|
|
conf = NewConfig()
|
|
|
|
conf.Settings["firewall"] = map[interface{}]interface{}{"inbound": []interface{}{map[interface{}]interface{}{"port": "1", "proto": "any", "group": "a", "groups": []string{"b", "c"}}}}
|
|
|
|
_, err = NewFirewallFromConfig(c, conf)
|
|
|
|
assert.EqualError(t, err, "firewall.inbound rule #0; only one of group or groups should be defined, both provided")
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestAddFirewallRulesFromConfig(t *testing.T) {
|
|
|
|
// Test adding tcp rule
|
|
|
|
conf := NewConfig()
|
|
|
|
mf := &mockFirewall{}
|
|
|
|
conf.Settings["firewall"] = map[interface{}]interface{}{"outbound": []interface{}{map[interface{}]interface{}{"port": "1", "proto": "tcp", "host": "a"}}}
|
|
|
|
assert.Nil(t, AddFirewallRulesFromConfig(false, conf, mf))
|
|
|
|
assert.Equal(t, addRuleCall{incoming: false, proto: fwProtoTCP, startPort: 1, endPort: 1, groups: nil, host: "a", ip: nil}, mf.lastCall)
|
|
|
|
|
|
|
|
// Test adding udp rule
|
|
|
|
conf = NewConfig()
|
|
|
|
mf = &mockFirewall{}
|
|
|
|
conf.Settings["firewall"] = map[interface{}]interface{}{"outbound": []interface{}{map[interface{}]interface{}{"port": "1", "proto": "udp", "host": "a"}}}
|
|
|
|
assert.Nil(t, AddFirewallRulesFromConfig(false, conf, mf))
|
|
|
|
assert.Equal(t, addRuleCall{incoming: false, proto: fwProtoUDP, startPort: 1, endPort: 1, groups: nil, host: "a", ip: nil}, mf.lastCall)
|
|
|
|
|
|
|
|
// Test adding icmp rule
|
|
|
|
conf = NewConfig()
|
|
|
|
mf = &mockFirewall{}
|
|
|
|
conf.Settings["firewall"] = map[interface{}]interface{}{"outbound": []interface{}{map[interface{}]interface{}{"port": "1", "proto": "icmp", "host": "a"}}}
|
|
|
|
assert.Nil(t, AddFirewallRulesFromConfig(false, conf, mf))
|
|
|
|
assert.Equal(t, addRuleCall{incoming: false, proto: fwProtoICMP, startPort: 1, endPort: 1, groups: nil, host: "a", ip: nil}, mf.lastCall)
|
|
|
|
|
|
|
|
// Test adding any rule
|
|
|
|
conf = NewConfig()
|
|
|
|
mf = &mockFirewall{}
|
|
|
|
conf.Settings["firewall"] = map[interface{}]interface{}{"inbound": []interface{}{map[interface{}]interface{}{"port": "1", "proto": "any", "host": "a"}}}
|
|
|
|
assert.Nil(t, AddFirewallRulesFromConfig(true, conf, mf))
|
|
|
|
assert.Equal(t, addRuleCall{incoming: true, proto: fwProtoAny, startPort: 1, endPort: 1, groups: nil, host: "a", ip: nil}, mf.lastCall)
|
|
|
|
|
|
|
|
// Test adding rule with ca_sha
|
|
|
|
conf = NewConfig()
|
|
|
|
mf = &mockFirewall{}
|
|
|
|
conf.Settings["firewall"] = map[interface{}]interface{}{"inbound": []interface{}{map[interface{}]interface{}{"port": "1", "proto": "any", "ca_sha": "12312313123"}}}
|
|
|
|
assert.Nil(t, AddFirewallRulesFromConfig(true, conf, mf))
|
|
|
|
assert.Equal(t, addRuleCall{incoming: true, proto: fwProtoAny, startPort: 1, endPort: 1, groups: nil, ip: nil, caSha: "12312313123"}, mf.lastCall)
|
|
|
|
|
|
|
|
// Test adding rule with ca_name
|
|
|
|
conf = NewConfig()
|
|
|
|
mf = &mockFirewall{}
|
|
|
|
conf.Settings["firewall"] = map[interface{}]interface{}{"inbound": []interface{}{map[interface{}]interface{}{"port": "1", "proto": "any", "ca_name": "root01"}}}
|
|
|
|
assert.Nil(t, AddFirewallRulesFromConfig(true, conf, mf))
|
|
|
|
assert.Equal(t, addRuleCall{incoming: true, proto: fwProtoAny, startPort: 1, endPort: 1, groups: nil, ip: nil, caName: "root01"}, mf.lastCall)
|
|
|
|
|
|
|
|
// Test single group
|
|
|
|
conf = NewConfig()
|
|
|
|
mf = &mockFirewall{}
|
|
|
|
conf.Settings["firewall"] = map[interface{}]interface{}{"inbound": []interface{}{map[interface{}]interface{}{"port": "1", "proto": "any", "group": "a"}}}
|
|
|
|
assert.Nil(t, AddFirewallRulesFromConfig(true, conf, mf))
|
|
|
|
assert.Equal(t, addRuleCall{incoming: true, proto: fwProtoAny, startPort: 1, endPort: 1, groups: []string{"a"}, ip: nil}, mf.lastCall)
|
|
|
|
|
|
|
|
// Test single groups
|
|
|
|
conf = NewConfig()
|
|
|
|
mf = &mockFirewall{}
|
|
|
|
conf.Settings["firewall"] = map[interface{}]interface{}{"inbound": []interface{}{map[interface{}]interface{}{"port": "1", "proto": "any", "groups": "a"}}}
|
|
|
|
assert.Nil(t, AddFirewallRulesFromConfig(true, conf, mf))
|
|
|
|
assert.Equal(t, addRuleCall{incoming: true, proto: fwProtoAny, startPort: 1, endPort: 1, groups: []string{"a"}, ip: nil}, mf.lastCall)
|
|
|
|
|
|
|
|
// Test multiple AND groups
|
|
|
|
conf = NewConfig()
|
|
|
|
mf = &mockFirewall{}
|
|
|
|
conf.Settings["firewall"] = map[interface{}]interface{}{"inbound": []interface{}{map[interface{}]interface{}{"port": "1", "proto": "any", "groups": []string{"a", "b"}}}}
|
|
|
|
assert.Nil(t, AddFirewallRulesFromConfig(true, conf, mf))
|
|
|
|
assert.Equal(t, addRuleCall{incoming: true, proto: fwProtoAny, startPort: 1, endPort: 1, groups: []string{"a", "b"}, ip: nil}, mf.lastCall)
|
|
|
|
|
|
|
|
// Test Add error
|
|
|
|
conf = NewConfig()
|
|
|
|
mf = &mockFirewall{}
|
|
|
|
mf.nextCallReturn = errors.New("test error")
|
|
|
|
conf.Settings["firewall"] = map[interface{}]interface{}{"inbound": []interface{}{map[interface{}]interface{}{"port": "1", "proto": "any", "host": "a"}}}
|
|
|
|
assert.EqualError(t, AddFirewallRulesFromConfig(true, conf, mf), "firewall.inbound rule #0; `test error`")
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestTCPRTTTracking(t *testing.T) {
|
|
|
|
b := make([]byte, 200)
|
|
|
|
|
|
|
|
// Max ip IHL (60 bytes) and tcp IHL (60 bytes)
|
|
|
|
b[0] = 15
|
|
|
|
b[60+12] = 15 << 4
|
|
|
|
f := Firewall{
|
|
|
|
metricTCPRTT: metrics.GetOrRegisterHistogram("nope", nil, metrics.NewExpDecaySample(1028, 0.015)),
|
|
|
|
}
|
|
|
|
|
|
|
|
// Set SEQ to 1
|
|
|
|
binary.BigEndian.PutUint32(b[60+4:60+8], 1)
|
|
|
|
|
|
|
|
c := &conn{}
|
|
|
|
setTCPRTTTracking(c, b)
|
|
|
|
assert.Equal(t, uint32(1), c.Seq)
|
|
|
|
|
|
|
|
// Bad ack - no ack flag
|
|
|
|
binary.BigEndian.PutUint32(b[60+8:60+12], 80)
|
|
|
|
assert.False(t, f.checkTCPRTT(c, b))
|
|
|
|
|
|
|
|
// Bad ack, number is too low
|
|
|
|
binary.BigEndian.PutUint32(b[60+8:60+12], 0)
|
|
|
|
b[60+13] = uint8(0x10)
|
|
|
|
assert.False(t, f.checkTCPRTT(c, b))
|
|
|
|
|
|
|
|
// Good ack
|
|
|
|
binary.BigEndian.PutUint32(b[60+8:60+12], 80)
|
|
|
|
assert.True(t, f.checkTCPRTT(c, b))
|
|
|
|
assert.Equal(t, uint32(0), c.Seq)
|
|
|
|
|
|
|
|
// Set SEQ to 1
|
|
|
|
binary.BigEndian.PutUint32(b[60+4:60+8], 1)
|
|
|
|
c = &conn{}
|
|
|
|
setTCPRTTTracking(c, b)
|
|
|
|
assert.Equal(t, uint32(1), c.Seq)
|
|
|
|
|
|
|
|
// Good acks
|
|
|
|
binary.BigEndian.PutUint32(b[60+8:60+12], 81)
|
|
|
|
assert.True(t, f.checkTCPRTT(c, b))
|
|
|
|
assert.Equal(t, uint32(0), c.Seq)
|
|
|
|
|
|
|
|
// Set SEQ to max uint32 - 20
|
|
|
|
binary.BigEndian.PutUint32(b[60+4:60+8], ^uint32(0)-20)
|
|
|
|
c = &conn{}
|
|
|
|
setTCPRTTTracking(c, b)
|
|
|
|
assert.Equal(t, ^uint32(0)-20, c.Seq)
|
|
|
|
|
|
|
|
// Good acks
|
|
|
|
binary.BigEndian.PutUint32(b[60+8:60+12], 81)
|
|
|
|
assert.True(t, f.checkTCPRTT(c, b))
|
|
|
|
assert.Equal(t, uint32(0), c.Seq)
|
|
|
|
|
|
|
|
// Set SEQ to max uint32 / 2
|
|
|
|
binary.BigEndian.PutUint32(b[60+4:60+8], ^uint32(0)/2)
|
|
|
|
c = &conn{}
|
|
|
|
setTCPRTTTracking(c, b)
|
|
|
|
assert.Equal(t, ^uint32(0)/2, c.Seq)
|
|
|
|
|
|
|
|
// Below
|
|
|
|
binary.BigEndian.PutUint32(b[60+8:60+12], ^uint32(0)/2-1)
|
|
|
|
assert.False(t, f.checkTCPRTT(c, b))
|
|
|
|
assert.Equal(t, ^uint32(0)/2, c.Seq)
|
|
|
|
|
|
|
|
// Halfway below
|
|
|
|
binary.BigEndian.PutUint32(b[60+8:60+12], uint32(0))
|
|
|
|
assert.False(t, f.checkTCPRTT(c, b))
|
|
|
|
assert.Equal(t, ^uint32(0)/2, c.Seq)
|
|
|
|
|
|
|
|
// Halfway above is ok
|
|
|
|
binary.BigEndian.PutUint32(b[60+8:60+12], ^uint32(0))
|
|
|
|
assert.True(t, f.checkTCPRTT(c, b))
|
|
|
|
assert.Equal(t, uint32(0), c.Seq)
|
|
|
|
|
|
|
|
// Set SEQ to max uint32
|
|
|
|
binary.BigEndian.PutUint32(b[60+4:60+8], ^uint32(0))
|
|
|
|
c = &conn{}
|
|
|
|
setTCPRTTTracking(c, b)
|
|
|
|
assert.Equal(t, ^uint32(0), c.Seq)
|
|
|
|
|
|
|
|
// Halfway + 1 above
|
|
|
|
binary.BigEndian.PutUint32(b[60+8:60+12], ^uint32(0)/2+1)
|
|
|
|
assert.False(t, f.checkTCPRTT(c, b))
|
|
|
|
assert.Equal(t, ^uint32(0), c.Seq)
|
|
|
|
|
|
|
|
// Halfway above
|
|
|
|
binary.BigEndian.PutUint32(b[60+8:60+12], ^uint32(0)/2)
|
|
|
|
assert.True(t, f.checkTCPRTT(c, b))
|
|
|
|
assert.Equal(t, uint32(0), c.Seq)
|
|
|
|
}
|
|
|
|
|
2019-12-13 22:45:21 +01:00
|
|
|
func TestFirewall_convertRule(t *testing.T) {
|
|
|
|
ob := &bytes.Buffer{}
|
|
|
|
out := l.Out
|
|
|
|
l.SetOutput(ob)
|
|
|
|
defer l.SetOutput(out)
|
|
|
|
|
|
|
|
// Ensure group array of 1 is converted and a warning is printed
|
|
|
|
c := map[interface{}]interface{}{
|
|
|
|
"group": []interface{}{"group1"},
|
|
|
|
}
|
|
|
|
|
|
|
|
r, err := convertRule(c, "test", 1)
|
|
|
|
assert.Contains(t, ob.String(), "test rule #1; group was an array with a single value, converting to simple value")
|
|
|
|
assert.Nil(t, err)
|
|
|
|
assert.Equal(t, "group1", r.Group)
|
|
|
|
|
|
|
|
// Ensure group array of > 1 is errord
|
|
|
|
ob.Reset()
|
|
|
|
c = map[interface{}]interface{}{
|
|
|
|
"group": []interface{}{"group1", "group2"},
|
|
|
|
}
|
|
|
|
|
|
|
|
r, err = convertRule(c, "test", 1)
|
|
|
|
assert.Equal(t, "", ob.String())
|
|
|
|
assert.Error(t, err, "group should contain a single value, an array with more than one entry was provided")
|
|
|
|
|
|
|
|
// Make sure a well formed group is alright
|
|
|
|
ob.Reset()
|
|
|
|
c = map[interface{}]interface{}{
|
|
|
|
"group": "group1",
|
|
|
|
}
|
|
|
|
|
|
|
|
r, err = convertRule(c, "test", 1)
|
|
|
|
assert.Nil(t, err)
|
|
|
|
assert.Equal(t, "group1", r.Group)
|
|
|
|
}
|
|
|
|
|
2019-11-19 18:00:20 +01:00
|
|
|
type addRuleCall struct {
|
|
|
|
incoming bool
|
|
|
|
proto uint8
|
|
|
|
startPort int32
|
|
|
|
endPort int32
|
|
|
|
groups []string
|
|
|
|
host string
|
|
|
|
ip *net.IPNet
|
|
|
|
caName string
|
|
|
|
caSha string
|
|
|
|
}
|
|
|
|
|
|
|
|
type mockFirewall struct {
|
|
|
|
lastCall addRuleCall
|
|
|
|
nextCallReturn error
|
|
|
|
}
|
|
|
|
|
|
|
|
func (mf *mockFirewall) AddRule(incoming bool, proto uint8, startPort int32, endPort int32, groups []string, host string, ip *net.IPNet, caName string, caSha string) error {
|
|
|
|
mf.lastCall = addRuleCall{
|
|
|
|
incoming: incoming,
|
|
|
|
proto: proto,
|
|
|
|
startPort: startPort,
|
|
|
|
endPort: endPort,
|
|
|
|
groups: groups,
|
|
|
|
host: host,
|
|
|
|
ip: ip,
|
|
|
|
caName: caName,
|
|
|
|
caSha: caSha,
|
|
|
|
}
|
|
|
|
|
|
|
|
err := mf.nextCallReturn
|
|
|
|
mf.nextCallReturn = nil
|
|
|
|
return err
|
|
|
|
}
|
2019-12-19 06:23:34 +01:00
|
|
|
|
|
|
|
func resetConntrack(fw *Firewall) {
|
2020-08-01 00:53:36 +02:00
|
|
|
fw.Conntrack.Lock()
|
|
|
|
fw.Conntrack.Conns = map[FirewallPacket]*conn{}
|
|
|
|
fw.Conntrack.Unlock()
|
2019-12-19 06:23:34 +01:00
|
|
|
}
|